Re: [9] Review Request - JDK-8055222: ISO 4217 Amendment #159

2014-08-29 Thread Naoto Sato
Hi Yong, The amendment also mentions to the name change "Cape Verde" -> "Cabo Verde." Should the change also include it? Naoto On 8/29/14, 12:47 AM, Yong Huang wrote: Hello, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8055222 Webrev: http://cr.openjdk.java.net/~yhuan

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-29 Thread Naoto Sato
I incorporated the suggestions from Mandy and Alan. Also one change since the last webrev was to revert the hard-coding of the supported locales list back to the one which dynamically generates the lists at the build time. I initially thought static listing of locales would be less complex as t

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-29 Thread Naoto Sato
On 8/29/14, 6:29 AM, Alan Bateman wrote: I'm still not sure about CLDRLocaleProviderAdapter throwing UOE when iterating over the installed LocaleDataMetaInfo implementations fail. It almost feels like it should be an InternalError as it could only mean something wrong with the JDK code or someth

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-29 Thread Naoto Sato
On 8/28/14, 5:11 PM, Mandy Chung wrote: Naoto, This looks better. Thanks for the update. The getSupportedLocaleString method in both EnLocaleDataMetaInfo and NonEnLocaleDataMetaInfo has the javadoc that missing the description. sun.util.locale.provider is a package in java.base and NonEnLocal

Re: [9] RFR 8038436: Re-examine the mechanism to determine available localedata and cldrdata

2014-08-29 Thread Alan Bateman
On 28/08/2014 19:34, Naoto Sato wrote: Thank you, Mandy, Masayoshi, and Alan for your comments. I revised the changes based on your suggestions as follows: http://cr.openjdk.java.net/~naoto/8038436/webrev.4/ Here are the changes since webrev.3 - CLDRLocaleProviderAdapter.java: modified to thr

[9] Review Request - JDK-8055222: ISO 4217 Amendment #159

2014-08-29 Thread Yong Huang
Hello, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8055222 Webrev: http://cr.openjdk.java.net/~yhuang/8055222/webrev.00/ thanks, Yong