Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
Thanks Masayoshi. Regards, Michael Sent from my iPhone > Masayoshi Okutsu 於 May 21, 2014 5:23 PM 寫道： > > Sorry, I forgot about LocaleDataTest. The fix looks good to me. > > Masayoshi > >> On 5/22/2014 9:13 AM, Michael Fang wrote: >> Hi all, >> >> I created a test build and ran regression te

Re: 8037343 Ready for merge

2014-05-21 Thread Masayoshi Okutsu
Sorry, I forgot about LocaleDataTest. The fix looks good to me. Masayoshi On 5/22/2014 9:13 AM, Michael Fang wrote: Hi all, I created a test build and ran regression tests. LocaleDataTest failed. I have updated the test data related to this bug fix. Please review the changes related to Local

Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
Hi all, I created a test build and ran regression tests. LocaleDataTest failed. I have updated the test data related to this bug fix. Please review the changes related to LocaleDataTest. http://cr.openjdk.java.net/~mfang/8037343/webrev.00/ thanks, -michael On 14年05月21日 12:15 下午, Michael Fa

Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
You are welcome, Sandipan. Thanks for your contribution. -michael On 14年05月21日 11:53 上午, Sandipan Razzaque wrote: Thanks Michael& team! Cheers, SR Sandipan Razzaque | www.sandipan.net On Wed, May 21, 2014 at 2:02 PM, Michael Fang wrote: Thanks Sandipan. I will work with our team to impo

Re: 8037343 Ready for merge

2014-05-21 Thread Sandipan Razzaque
Thanks Michael & team! Cheers, SR Sandipan Razzaque | www.sandipan.net On Wed, May 21, 2014 at 2:02 PM, Michael Fang wrote: > Thanks Sandipan. > > I will work with our team to import, test, and push it to jdk9. > > thanks, > > -michael > > On 14年05月21日 06:18 上午, Sandipan Razzaque wrote: >> >> H

Re: 8037343 Ready for merge

2014-05-21 Thread Michael Fang
Thanks Sandipan. I will work with our team to import, test, and push it to jdk9. thanks, -michael On 14年05月21日 06:18 上午, Sandipan Razzaque wrote: Hi all, Take 2 - inlined into the email this time. Cheers, SR --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java 2014-05-14 2

Re: [9] RFR: 8032650: jdk/src/share/native/java/util: jni exception pending

2014-05-21 Thread Naoto Sato
OK. Fair enough. Naoto On 5/21/26 H, 2:01 AM, Masayoshi Okutsu wrote: Yes, we should. But it's a lot of work if we clean up old tools as well. I'd like to fix this one first. Masayoshi On 5/20/2014 7:20 AM, Naoto Sato wrote: The fix itself looks good to me. However, there are pieces of code

Re: 8037343 Ready for merge

2014-05-21 Thread Sandipan Razzaque
Hi all, Take 2 - inlined into the email this time. Cheers, SR --- old/src/share/classes/sun/text/resources/es/FormatData_es_DO.java 2014-05-14 22:28:33.393717389 -0400 +++ new/src/share/classes/sun/text/resources/es/FormatData_es_DO.java 2014-05-14 22:28:33.277717384 -0400 @@ -75,8 +75,8 @@

8037343 Ready for merge

2014-05-21 Thread Sandipan Razzaque
Hi all, Patch 8037343 has been reviewed and is ready for merge. Please find it attached to this email. Cheers, SR Sandipan Razzaque | www.sandipan.net

Re: [9] RFR: 8032650: jdk/src/share/native/java/util: jni exception pending

2014-05-21 Thread Masayoshi Okutsu
Yes, we should. But it's a lot of work if we clean up old tools as well. I'd like to fix this one first. Masayoshi On 5/20/2014 7:20 AM, Naoto Sato wrote: The fix itself looks good to me. However, there are pieces of code that deal with Windows releases that are no longer supported. Should we