Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2014-01-07 Thread Michael Fang
Thank you Yong for the review feedback. I did not include them in LocaleData because these are just translation of names and not format changes. If you think they should be in LocaleData, please file a separate bug to be taken care of separately as a test bug. thanks, -michael On 14年01月07日

Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2014-01-07 Thread Yong Huang
Hi Michael, I think you also need to modify test/sun/text/resources/LocaleData so that those locale name change will be checked by regression test. thanks, Yong On 2014/1/8 12:02, Michael Fang wrote: Hi Masayoshi, Since the changes to the LocaleNames translation might have slight chance of

Re: [8] Request for review: 8029239: jdk8 l10n resource file translation update - localenames

2014-01-07 Thread Michael Fang
Hi Masayoshi, Since the changes to the LocaleNames translation might have slight chance of backward compatibility risk (if the users hardcode the names in their program or tests, both not recommended), I have decided to re-do the work and only apply missing names to existing files. The webrev

Re: [8] Request for review: 8026570: NLS: jdk8 man page update

2014-01-07 Thread Naoto Sato
OK. Then the l10n part looks good to me. Naoto On 1/7/14, 10:56 AM, Michael Fang wrote: Thanks Naoto for the review. For jdeps.1 and jjs.1, even the English man pages are not packaged into the build (but are in the repo). A bug JDK-8031300 has

Re: [8] Request for review: 8026570: NLS: jdk8 man page update

2014-01-07 Thread Michael Fang
Thanks Naoto for the review. For jdeps.1 and jjs.1, even the English man pages are not packaged into the build (but are in the repo). A bug JDK-8031300 has been filed and further changes to make/Images.gmk is needed. A similar issue of missi

Re: [8] Request for review: 8026570: NLS: jdk8 man page update

2014-01-07 Thread Naoto Sato
Hi Michael, jcmd.1 looks fine to me, however, what about the other two new ja man pages, i.e., jdeps and jjs? I could not find them in the artifact link you provided below. Naoto On 1/6/14, 8:06 PM, Michael Fang wrote: Found the source of the jcmd.1 corruption issue. jdk/make/Images.gmk 45