Re: [8] Request for review: 8027244: Need to translate new error message and usage information for jar tool

2013-11-27 Thread Michael Fang
Thank you Naoto for the review! -michael On 13年11月27日 10:04 上午, Naoto Sato wrote: Looks good to me. Naoto On 13-11-26 下午4:00, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8027244 The webrev is available here: http:

Re: [8] Request for review: 8027244: Need to translate new error message and usage information for jar tool

2013-11-27 Thread Naoto Sato
Looks good to me. Naoto On 13-11-26 下午4:00, Michael Fang wrote: Hi, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-8027244 The webrev is available here: http://cr.openjdk.java.net/~mfang/8027244/ Only 2 lines were changed in each file which c

Re: [8] RFR: 8028771: regression test java/util/Locale/LocaleProviders.sh failed

2013-11-27 Thread Naoto Sato
Thanks, Alan. That's exactly what the fix is intended for. Naoto On 13-11-27 上午8:45, Alan Bateman wrote: On 27/11/2013 16:19, Naoto Sato wrote: Ping. I need to push this by 12/04, so your help is needed. Naoto If I understand correctly then it just means the tests silently passes when run on

Re: [8] RFR: 8028771: regression test java/util/Locale/LocaleProviders.sh failed

2013-11-27 Thread Alan Bateman
On 27/11/2013 16:19, Naoto Sato wrote: Ping. I need to push this by 12/04, so your help is needed. Naoto If I understand correctly then it just means the tests silently passes when run on systems that are configured in a manner that requires a calendar that the JDK doesn't support. In that cas

Re: [8] RFR: JDK-8028368 : There is no description whether or not java.util.ResourceBundle is thread-safe

2013-11-27 Thread Naoto Sato
And this one too. Thanks! Naoto On 13-11-25 上午10:49, Naoto Sato wrote: Hello, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8028368 The proposed changeset is here: http://cr.openjdk.java.net/~naoto/8028368/webrev.00/ It is just a clarification of t

Re: [8] RFR: 8028771: regression test java/util/Locale/LocaleProviders.sh failed

2013-11-27 Thread Naoto Sato
Ping. I need to push this by 12/04, so your help is needed. Naoto On 13-11-26 上午11:16, Naoto Sato wrote: Hello, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8028771 Here is the proposed fix: http://cr.openjdk.java.net/~naoto/8028771/webrev.00/ The