Re: [8]: diff patch for jdk test on a non US platform

For those tests that are locale sensitive, basic approach should be like: Locale defaultLocale = Locale.getDefault(); try { Locale.setDefault(); } finally { Locale.setDefault(defaultLocale); } However, it looks to me that those tests in ResourceBundle are already capable of whate

Re: [8]: diff patch for jdk test on a non US platform

On 11/4/13 7:39 PM, Francis ANDRE wrote: Stuart. the jtreg jdk test should pass OK on all platforms where OpenJDK could be build. Yes. On this, we agree. At least, all the tests should pass, on platforms and locales that OpenJDK supports. It looks like localizations are present in OpenJDK f

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

Sherman, Thank you for a quick review. I totally agree with you on all items. Actually, I missed fact that the transitions are sorted. And yes - the change can be done on line #431. The new tested fix can be found here: http://cr.openjdk.java.net/~aefimov/8027848/webrev.01/

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

On 11/05/2013 10:50 AM, Xueming Shen wrote: Aleksej, For better performance (1) the currT should be "static final" so we dont have to access the System.curentTimeMillis() for each TimeZone/ZoneInfo instance. (2) instead of iterating through the standardTransitions(), shouldn't we just check the

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

Aleksej, For better performance (1) the currT should be "static final" so we dont have to access the System.curentTimeMillis() for each TimeZone/ZoneInfo instance. (2) instead of iterating through the standardTransitions(), shouldn't we just check the last one? given it's a sorted list. btw, in

Re: RFR: 8027370: (tz) Support tzdata2013h

Alan, Thank you for advise. I have executed the same test sets with -XX:-UseMathExactIntrinsics and, as was expected, there is only one failure: sun/util/calendar/zi/TestZoneInfo310.java. -Aleksej On 11/05/2013 09:50 PM, Alan Bateman wrote: On 05/11/2013 16:38, Aleksej Efimov wrote: Hi, Ca

Re: RFR: 8027370: (tz) Support tzdata2013h

On 05/11/2013 16:38, Aleksej Efimov wrote: Hi, Can I have a review for tzdata2013h integration [1]. The webrev link can be located here [2]. The following test sets were executed on build with fix: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

Adding i18n-dev as this is the mailing list where this area is maintained. On 05/11/2013 17:26, Aleksej Efimov wrote: Hi, Can I have a review for a 8027848 [1] bug fix . There is unimplemented functionality related to the future GMT offset changes. The ZoneInfoFile class doesn't analyses if th

Re: [8]: diff patch for jdk test on a non US platform

Hi Michael Le 05/11/2013 06:56, Michael Fang a écrit : Hi Francis, I am the one coordinating the translation of resource files. I have asked the translators about the extra space in the past for another file and they replied: Please note that this is not an error but a French standard. In Fre

RFR: 8027370: (tz) Support tzdata2013h

Hi, Can I have a review for tzdata2013h integration [1]. The webrev link can be located here [2]. The following test sets were executed on build with fix: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone test/java/