Re: [8] Request for review: 6931564: Incorrect display name of Locale for south africa

2013-10-30 Thread Michael Fang
Hi Naoto, Thanks for the info. Let me check about it. I will file a separate bug for it. thanks, -michael On 13年10月30日 10:29 上午, Naoto Sato wrote: Hi Michael, I just skimmed through resource files, and found other instances that end with spaces. IIRC, build or release team will take care

Re: [8] Request for review: 6931564: Incorrect display name of Locale for south africa

2013-10-30 Thread Naoto Sato
Hi Michael, I just skimmed through resource files, and found other instances that end with spaces. IIRC, build or release team will take care of them with some script execution (might be wrong). So first can you check with them whether they will do this kind of clean up at the end? If not, can

Re: [8] Request for review: 6192407: s10_70, ko, s1/dvd, minor misspelling under "Select Software Localizations" window

2013-10-30 Thread Naoto Sato
Looks good to me. Naoto On 10/29/13 11:43 PM, Michael Fang wrote: Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6192407 The webrev is available here: http://cr.openjdk.java.net/~mfang/6192407/ thanks, -michael

Re: [8] Request for review: 6931564: Incorrect display name of Locale for south africa

2013-10-30 Thread Yong Huang
It looks good to me. thanks, Yong On 2013/10/30 14:59, Michael Fang wrote: Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6931564 The webrev is available here: http://cr.openjdk.java.net/~mfang/6931564/ (Please ignore the part for 61924

Re: [8] Request for review: 6192407: s10_70, ko, s1/dvd, minor misspelling under "Select Software Localizations" window

2013-10-30 Thread Yong Huang
It looks good to me. thanks, Yong On 2013/10/30 14:43, Michael Fang wrote: Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6192407 The webrev is available here: http://cr.openjdk.java.net/~mfang/6192407/ thanks, -michael

[8] Request for review: 6931564: Incorrect display name of Locale for south africa

2013-10-30 Thread Michael Fang
Hello, Please help to review the changes for the following CR: https://bugs.openjdk.java.net/browse/JDK-6931564 The webrev is available here: http://cr.openjdk.java.net/~mfang/6931564/ (Please ignore the part for 6192407 which shares the same regression test program) The diff is not very obvi