Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
Agreed. It was unnecessary, but it was the practice at that time. thanks, -michael On 13?10?24? 01:55 ??, Masayoshi Okutsu wrote: The test detected the translation changes as regression, but that was unnecessary? I prefer to remove this test rather than changing the data. Thanks, Masayoshi

Re: Request for approval for 8025255: (tz) Support tzdata2013g

2013-10-24 Thread Seán Coffey
Good to put the test on ProblemList for short term Aleksej. Approved for 7u-dev. For records, I'm pasting bug ID and jdk8 changeset here again. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8025255 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60e3cdbe8cdf regards, Sean. On 24/10/2013 13:56

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
Hi Aleksej, The proposed change is fine for me. thanks, -michael On 13?10?24? 06:32 ??, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch locat

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Aleksej Efimov
Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch located here: http://cr.openjdk.java.net/~aefimov/8026772/8026772_jdk8.patch. Thank you, Aleksej On 10/24/2013 04:27

Re: Request for approval for 8025255: (tz) Support tzdata2013g

2013-10-24 Thread Aleksej Efimov
The new webrev [1] contains the fixed test (it was also added to ProblemsList.txt) and the same tzdata2013g related update. -Aleksej [1] http://cr.openjdk.java.net/~aefimov/8025255/7/webrev.01/ On 10/24/2013 04:08 PM, Aleksej Efimov wrote: Ok, The fix for failed time zone names test (JDK-8026

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Aleksej Efimov
Alan, I have added this test to ProblemList.txt and keep the test update: http://cr.openjdk.java.net/~aefimov/8026772/webrev.01/. I suppose, with such resolution we can safely close this minor bug. And we will decide this test destiny in 8025051. Thanks, Aleksej On 10/24/2013 04:00 PM, Alan B

Re: Request for approval for 8025255: (tz) Support tzdata2013g

2013-10-24 Thread Aleksej Efimov
Ok, The fix for failed time zone names test (JDK-8026772) is under review. Currently, there is a discussion about test - should we remove it or update, but anyway the time zone names and tzdata will remain untouched. So we can proceed with pushing this backport to 7u-dev. Thanks you, Aleksej

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Alan Bateman
On 24/10/2013 10:05, Aleksej Efimov wrote: Masayoshi, As Michael said, the time zone names changes is not finalized yet and I'll add new regression test as part of 8025051 and will remove this one. So, I suggest to keep this test and later remove it. I prefer not just remove a workable/questio

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Aleksej Efimov
Masayoshi, As Michael said, the time zone names changes is not finalized yet and I'll add new regression test as part of 8025051 and will remove this one. So, I suggest to keep this test and later remove it. I prefer not just remove a workable/questionable test, but add some replacement for it.

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Masayoshi Okutsu
The test detected the translation changes as regression, but that was unnecessary? I prefer to remove this test rather than changing the data. Thanks, Masayoshi On 10/24/2013 12:12 AM, Michael Fang wrote: Hi Masayoshi, At that time I was asked to have regression test to validate each transla