Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Michael Fang
Hi Aleksej, Yes, you are right. They can be handled separately. Thanks! Regards, Michael Sent from my iPhone On Oct 11, 2013, at 12:20 PM, Aleksej Efimov wrote: > Hi Michael, > As I can see this topic was touched a little here: > http://mail.openjdk.java.net/pipermail/threeten-dev/2012-Decem

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Aleksej Efimov
Hi Michael, As I can see this topic was touched a little here: http://mail.openjdk.java.net/pipermail/threeten-dev/2012-December/000314.html. AFAIU from the above discussion the CLDR generic names were translated in all locales, but the legacy JRE time zone names doesn't contain this translati

Re: RFR: JDK-8025712, , (props) Possible memory leak in java_props_md.c / ParseLocale

2013-10-11 Thread Naoto Sato
Looks good. Thank you for fixing this. Naoto On 10/10/13 7:46 PM, Dan Xu wrote: Thanks for your clarification, Naoto. Here is the updated webrev, http://cr.openjdk.java.net/~dxu/8025712/webrev.01/. Please help review it. -Dan On 10/10/2013 03:14 PM, Naoto Sato wrote: You could, but that par

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Michael Fang
Hi Aleksej, I took a look at the localized TimeZoneNames_*.java files. They do not contain generic time zone names for JSR310... I think we can file a separate bug to track that issue. thanks, -michael On 13年10月10日 09:54 下午, Masayoshi Okutsu wrote: Hi Aleksej, Here are my review comments.

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Aleksej Efimov
Hi Masayoshi, The new webrev with addressed review comments: http://cr.openjdk.java.net/~aefimov/8025255/8/webrev.01/ The list of changes: 1. "Middle Europe Time" remained untouched. 2. The copyright headers were added. Best Regards

Re: RFR: JDK-8025712, , (props) Possible memory leak in java_props_md.c / ParseLocale

2013-10-11 Thread Chris Hegarty
Thanks Dan, looks good to me. -Chris. On 11/10/2013 03:46, Dan Xu wrote: Thanks for your clarification, Naoto. Here is the updated webrev, http://cr.openjdk.java.net/~dxu/8025712/webrev.01/. Please help review it. -Dan On 10/10/2013 03:14 PM, Naoto Sato wrote: You could, but that part only

Re: RFR: 8025255: (tz) Support tzdata2013g

2013-10-11 Thread Aleksej Efimov
Hi Masayoshi, Thank you for your comments. Replies are below. On 10/11/2013 08:54 AM, Masayoshi Okutsu wrote: Hi Aleksej, Here are my review comments. - The copyright header of the data files shouldn't be removed. The copyright header is absent in raw tzdata2013g release (in tzdata2013g.tar.g