Review Request - 6964022: Java.util.Currency.getSymbol(Locale) returns wrong value when locale is not US

Hello, This is the review request for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6964022 Webrev: http://cr.openjdk.java.net/~yhuang/6964022/webrev.00/ thanks, Yong

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

Thanks Joe. -michael On 06/18/13 22:44, huizhe wang wrote: Looks great! Thanks for taking the time to fix the legal notice. -Joe On 6/18/2013 10:41 PM, Michael Fang wrote: Hi Joe, I have updated the copyright. The webrev has been updated at: http://cr.openjdk.java.net/~mfang/8016824/webr

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

Looks great! Thanks for taking the time to fix the legal notice. -Joe On 6/18/2013 10:41 PM, Michael Fang wrote: Hi Joe, I have updated the copyright. The webrev has been updated at: http://cr.openjdk.java.net/~mfang/8016824/webrev.jaxp.01/ thanks, -michael On 06/18/13 10:13, Michael Fa

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

Hi Joe, I have updated the copyright. The webrev has been updated at: http://cr.openjdk.java.net/~mfang/8016824/webrev.jaxp.01/ thanks, -michael On 06/18/13 10:13, Michael Fang wrote: Hi Joe, I see. This is not part of automated translation process. Let me see what I can do. thanks, -

[8] Request for Review: 6863624 : java/util/Currency/PropertiesTest.sh writable check is incorrect

Hello, Please review this test case fix: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6863624 http://cr.openjdk.java.net/~naoto/6863624/webrev.00/ Basically it enforces the check for non-writable JDKs, with a workaround for Cygwin's inconsistent behavior for `test` command. Changes for

Re: [8]Request for review: 8015657: jdk8 l10n resource file translation update 3

Thanks Naoto for the review. -michael On 06/18/13 11:52, Naoto Sato wrote: Looks good to me. Naoto On 6/17/13 10:42 PM, Michael Fang wrote: Hello, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8015657 A list of English resource files are sen

Re: [8]Request for review: 8015657: jdk8 l10n resource file translation update 3

Looks good to me. Naoto On 6/17/13 10:42 PM, Michael Fang wrote: Hello, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8015657 A list of English resource files are sent to translation group for translation update periodically that's why these l1

Re: [8] Request for review: 8011870: i18n translations for JDK-8009636

在 Jun 18, 2013，2:44 PM，huizhe wang 写道： > Hi Michael, > > I think you meant to ask Max to review this one. I guess so. Michael, I'm on vacation this week. Will look at it next week. Thanks Max > > -Joe > > On 6/17/2013 11:02 PM, Michael Fang wrote: >> Hi Joe and all, >> >> Please help t

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

Hi Joe, I see. This is not part of automated translation process. Let me see what I can do. thanks, -michael On 06/18/13 10:07, huizhe wang wrote: Hi Michael, The English came from Apache, a header was added there. So we'll need to add the Apache header when we update (which we plan to do

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

Hi Michael, The English came from Apache, a header was added there. So we'll need to add the Apache header when we update (which we plan to do in the next project). The other language files were added by Oracle, reflecting the internationalization effort by Oracle. I think those Oracle copyr

Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

Hi Joe, The translation team uses the English file as template and updated the l10n files to match. So, in these cases, the corresponding English resource files do not have these copyright headers, the l10n files were updated accordingly. Is this a problem? thanks, -michael On 06/17/13 23:

Re: [8] Request for review: 8011870: i18n translations for JDK-8009636

Thank you Max! -michael On 06/18/13 02:25, Wang Weijun wrote: 在 Jun 18, 2013，2:44 PM，huizhe wang > 写道： Hi Michael, I think you meant to ask Max to review this one. I guess so. Michael, I'm on vacation this week. Will look at it next week. Thanks Max -