Re: [8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-17 Thread huizhe wang
Hi Michael, Thanks for translating the new messages. I noticed that except XMLMessages, XMLSchemaMessages, and new language resources for XPath, others are mostly removing the Oracle copyright header. Should the header be removed? Other than the original English source file, others were add

Re: [8] Request for review: 8011870: i18n translations for JDK-8009636

2013-06-17 Thread huizhe wang
Hi Michael, I think you meant to ask Max to review this one. -Joe On 6/17/2013 11:02 PM, Michael Fang wrote: Hi Joe and all, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8011870 The webrev is available here: http://cr.openjdk.java.net/~mfang/

Re: [8]Request for review: 8015657: jdk8 l10n resource file translation update 3

2013-06-17 Thread Michael Fang
Thank you Yong for the review! -michael On 06/17/13 22:58, Yong Huang wrote: It looks good to me based on our internal testing, http://aseng-wiki.us.oracle.com/asengwiki/display/i18n/JDK+8+Message+Drop+30+PIT1+Test Some bugs are filed, but it should be OK to integrate current l10n change.

[8] Request for review: 8011870: i18n translations for JDK-8009636

2013-06-17 Thread Michael Fang
Hi Joe and all, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8011870 The webrev is available here: http://cr.openjdk.java.net/~mfang/8011870/ It's part of webrev for 8015657: jdk8 l10n resource file translation update 3 Please only look at the

Re: [8]Request for review: 8015657: jdk8 l10n resource file translation update 3

2013-06-17 Thread Yong Huang
It looks good to me based on our internal testing, http://aseng-wiki.us.oracle.com/asengwiki/display/i18n/JDK+8+Message+Drop+30+PIT1+Test Some bugs are filed, but it should be OK to integrate current l10n change. thanks, Yong On 2013/6/18 13:42, Michael Fang wrote: Hello, Please help to revi

[8] Request for review: 8016824: jdk8 l10n resource file translation update 3 - jaxp

2013-06-17 Thread Michael Fang
Hi Joe, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8016824 A list of English resource files are sent to translation group for translation update periodically that's why these l10n resource files have been updated. You do not need to review

[8]Request for review: 8015657: jdk8 l10n resource file translation update 3

2013-06-17 Thread Michael Fang
Hello, Please help to review the changes for the following CR: http://bugs.sun.com/view_bug.do?bug_id=8015657 A list of English resource files are sent to translation group for translation update periodically that's why these l10n resource files have been updated. You do not need to review t

Re: Review Request - 8013836 : getFirstDayOfWeek reports wrong day for pt-BR locale

2013-06-17 Thread Yong Huang
Hi Michael, Since you are more familiar with the copyright in resource files, I'd like to get your help first. :-) I copy CalendarData_pt.properties to CalendarData_pt_BR.properties and make some modification on it. Do I still need to keep Taligent/IBM copyright in the new file? If you are a

Re: Review Request - 8013836 : getFirstDayOfWeek reports wrong day for pt-BR locale

2013-06-17 Thread Naoto Sato
IANAL, but I am not sure whether the Taligent/IBM copyright notice is needed, since you've created it. Can you please check it with the legal? Naoto On 6/16/13 8:20 PM, Yong Huang wrote: Hi Naoto, Thanks for the review. The revised webrev is at http://cr.openjdk.java.net/~yhuang/8013836/webr