Hello,
This is a review request for the fix of 7177315: SimpleDateFormat parses
wrong 2-digit year if input contains spaces
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7177315
Webrev:
http://cr.openjdk.java.net/~okutsu/8/7177315/webrev.00/
Thanks,
Masayoshi
When I noticed the warning, actually I tried the exactly same fix (both
equals and hashCode). It was supposed to generate the same data after
the fix, but the fixed one didn't generate identical data. I haven't had
time to look into it further.
Yesterday Yuka looked into the fixed tool and con
I'd compare the generated break iterator data binary before and after
the fix to make sure it is not affecting the compatibility.
Naoto
On 6/5/13 1:27 PM, Alan Bateman wrote:
On 05/06/2013 18:47, Naoto Sato wrote:
What about the regression risk? With this fix, the equality would
differ from t
On 05/06/2013 18:47, Naoto Sato wrote:
What about the regression risk? With this fix, the equality would
differ from the prior releases. Would that be ignorable?
Naoto
This is the tool used in the build, it's the generated data files are
that included in the runtime. I've run the regression te
What about the regression risk? With this fix, the equality would differ
from the prior releases. Would that be ignorable?
Naoto
On 6/5/13 12:23 AM, Yuka Kamiya wrote:
Hi Alan,
Thank you for taking care of this.
I investigated how the method had been used. Your fix looks okay. It is
not only
Hi Alan,
Thank you for taking care of this.
I investigated how the method had been used. Your fix looks okay. It is not
only safe but improves the generator's behavior.
I think that we were just lucky that the method had merely wasted CPU and
didn't cause a worse problem
Thanks,
--
Yuka
