Re: RFR JDK-8013386: (tz) Support tzdata2013c

2013-05-09 Thread Xueming Shen
On 5/9/13 9:57 PM, Masayoshi Okutsu wrote: Do we still need to keep the old javazic code in JDK8? It's a maintenance burden to maintain both, isn't it? While it's a burden, but somehow it serves as a test case pretty well. The transitions are being built the "old" jdk way and threeten way, i

Re: RFR JDK-8013386: (tz) Support tzdata2013c

2013-05-09 Thread Masayoshi Okutsu
Do we still need to keep the old javazic code in JDK8? It's a maintenance burden to maintain both, isn't it? I'm concerned about the 24:00 fix. Is there any way to produce the correct rules without hard coding time zone IDs? Masayoshi On 5/10/2013 8:24 AM, Xueming Shen wrote: Hi Sean, Than

Re: RFR JDK-8013386: (tz) Support tzdata2013c

2013-05-09 Thread Xueming Shen
Hi Sean, Thanks for the review. It appears I missed jdk/test/sun/util/calendar/zi/tzdata, webrev has been updated to include the test data update. http://cr.openjdk.java.net/~sherman/8013386/webrev I will update TCKZoneRulesProvider.java separately in JSR310 repo, this def is actually is not be

Re: Slovenia Pre Euro currency problem

2013-05-09 Thread Naoto Sato
Hi Deven, Are those "EURO"/"PREEURO" variants IBM proprietary locales? I don't think they are available in OpenJDK. As to adding those variants, I am not sure that is the way to go, in terms of adding them as generic locales. Currency variants should be dealt with BCP 47's extension. Naoto

Re: RFR JDK-8013386: (tz) Support tzdata2013c

2013-05-09 Thread Seán Coffey
Thanks for taking care of this Sherman. I was wondering what sort of impact JSR 310 would make on tzdata updates. The Atlantic/Stanley display name issue mentioned is a regular one, we should log a bug against the test file generation scripts. I just had a quick grok of the jdk8 repo. The foll

Re: Slovenia Pre Euro currency problem

2013-05-09 Thread Deven You
Hi All, I don't know why the mail signed out without my attached test case. I have copied it[3] into cr.openjdk.java.net. [3] http://cr.openjdk.java.net/~youdwei/ojdk-667/TestCurr_Slovenia.java Thanks a lot! On 05/09/20