Re: [8] RFR: 8013086 : NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied

2013-04-26 Thread Naoto Sato
Thank you for the comment. Updated the fix (just moved the following if in front of the for-loop). http://cr.openjdk.java.net/~naoto/8013086/webrev.01/ Naoto On 4/26/13 1:46 AM, Masayoshi Okutsu wrote: I'd suggest that the for loop and the following if-statement be combined and optimized. Ma

Re: [8] RFR: 8013086 : NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied

2013-04-26 Thread Naoto Sato
On 4/26/13 8:57 AM, Yoshito Umaoka wrote: I'm afraid that the fix above is not what I wanted. Your proposed fix - fallback to standard name when daylight name is missing, and long name when short name is missing. I think the right fix would be querying a localized name from another provide in th

Re: [8] RFR: 8013086 : NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied

2013-04-26 Thread Yoshito Umaoka
On 4/25/2013 5:21 PM, Naoto Sato wrote: Hello, Please review the fix for the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013086 The fix is to complement the missing display names with the provided ones for TimeZoneNameProvider implementations. http://cr.openjdk.java.n

Re: [8] RFR: 8013086 : NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied

2013-04-26 Thread Masayoshi Okutsu
I'd suggest that the for loop and the following if-statement be combined and optimized. Masayoshi On 4/26/2013 6:21 AM, Naoto Sato wrote: Hello, Please review the fix for the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013086 The fix is to complement the missing displ