Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Michael Fang
Thanks Naoto for the review. JDK-8010782 has been created to track the Windows new line character issue (^M) thanks, -michael On 13年03月25日 02:41 下午, Naoto Sato wrote: On 3/25/13 2:29 PM, Michael Fang wrote: Hi Naoto, After further review, s

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Naoto Sato
On 3/25/13 2:29 PM, Michael Fang wrote: Hi Naoto, After further review, synth_zh_TW.properties webrev was correct. 45 lines changed: 0 ins; 0 del; 45 mod; 0 unchg The dev team updated all synth_*.properties files to fix bug 7093156 and they saved the files with ^M windows new line characters. B

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Michael Fang
Hi Naoto, After further review, synth_zh_TW.properties webrev was correct. 45 lines changed: 0 ins; 0 del; 45 mod; 0 unchg The dev team updated all synth_*.properties files to fix bug 7093156 and they saved the files with ^M windows new line characters. But the files delivered from translation

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Naoto Sato
On 3/25/13 12:50 PM, Michael Fang wrote: Hi Naoto, Thank you so much for your review. Please see my comments inline below. thanks, -michael On 13年03月25日 11:37 上午, Naoto Sato wrote: Hi Michael, I haven't looked into the actual translations, but here are my comments to your changes. All are i

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Michael Fang
Hi Naoto, Thank you so much for your review. Please see my comments inline below. thanks, -michael On 13年03月25日 11:37 上午, Naoto Sato wrote: Hi Michael, I haven't looked into the actual translations, but here are my comments to your changes. All are in the jdk repository: - src/share/clas

Re: [8]Request for review: 8010521: jdk8 l10n resource file translation update

2013-03-25 Thread Naoto Sato
Hi Michael, I haven't looked into the actual translations, but here are my comments to your changes. All are in the jdk repository: - src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties: There seems to be no change in this file. - src/share/classes/sun/too