Re: [7u10] Request for approval: 7174233: Openjdk is missing some key maps on the Japanese keyboards

2012-09-18 Thread Naoto Sato
While I think fix looks good (that's why I approved the change in jdk8), I don't find any reason for backporting this change into 7u line. Is there any strong reason for backport? Naoto On 9/18/12 10:37 AM, Seán Coffey wrote: cc'ing i18n-dev alias here also. i18n fixes can be difficult to tes

Re: [PATCH] Review Request: Add bug 7196199 into ProblemList

2012-09-18 Thread Naoto Sato
The fix has been pushed to T/L repository. Naoto On 9/18/12 1:40 AM, Alan Bateman wrote: On 17/09/2012 22:53, Naoto Sato wrote: OK, I filed a CR 7198984 for this and intend to push Eric's fix as it is. Alan, will you be a reviewer for this? Naoto That's fine. -Alan

Re: [7u10] Request for approval: 7174233: Openjdk is missing some key maps on the Japanese keyboards

2012-09-18 Thread Seán Coffey
cc'ing i18n-dev alias here also. i18n fixes can be difficult to test. Was it possible to verify this fix on jdk7u Shi Jun ? Any thoughts from i18n reviewers on this one being backported to 7u ? regards, Sean. On 17/09/2012 08:07, Shi Jun Zhang wrote: Hi all, I'd like to request for approval

Re: [PATCH] Review Request: Add bug 7196199 into ProblemList

2012-09-18 Thread Alan Bateman
On 17/09/2012 22:53, Naoto Sato wrote: OK, I filed a CR 7198984 for this and intend to push Eric's fix as it is. Alan, will you be a reviewer for this? Naoto That's fine. -Alan