Re: Review request : 7180362: RFE: Implement date cutover functionality for currency.properties file

2012-08-29 Thread mark . reinhold
2012/8/29 14:00 -0700, scolebou...@joda.org: > I object to the implementation of this change, specifically the date format - > "The format of date must be {@code '-MM-dd-HH-mm-ss'}" > > There seems to be no reason not to use the standard ISO-8601 format > here - -MM-dd'T'HH:mm:ss I agree.

Re: Review request : 7180362: RFE: Implement date cutover functionality for currency.properties file

2012-08-29 Thread Stephen Colebourne
I object to the implementation of this change, specifically the date format - "The format of date must be {@code '-MM-dd-HH-mm-ss'}" There seems to be no reason not to use the standard ISO-8601 format here - -MM-dd'T'HH:mm:ss Stephen co-spec lead JSR-310 On 28 August 2012 14:48, Seán Co

Re: Review request : 7180362: RFE: Implement date cutover functionality for currency.properties file

2012-08-29 Thread Naoto Sato
Hi Sean, It looks good overall. There are some minor comments that I have below. All in Currency.java Line 666: Comments refer to "GMT", while the class description uses "UTC." I'd use "UTC" here as well (and in the actual code on line 728). Line 681, "countOccurrences(curdata, ',') == 3":