Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-25 Thread Xueming Shen
On 6/25/12 10:58 PM, Xueming Shen wrote: Hi, While I still believe that case-insensitive is the right choice for File/Path on MacOSX, it is suggested that we might want to be a little conservative in this patch, with the assumption that this patch will be backport to 7u release after being bak

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-25 Thread David Kocher
Will this address issue MACOSX_PORT-165 [1]? [1] http://java.net/jira/browse/MACOSX_PORT-165 -- David On 22.06.2012, at 19:01, Xueming Shen wrote: > Hi > > Here is the proposed change to support Unicode nfd/nfc and case insensitive > file path on MacOSX file system. > > 7130915: File.equals

Re: Fwd: Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-06-25 Thread Jonathan Lu
Hi Naoto, On 06/22/2012 12:51 AM, Naoto Sato wrote: OK so you want to limit the character counts for each format element, then I don't know of any way out of the box. You might want to create a subclass of DateFormatSymbols in which you want to truncate It sounds reasonable but a little comp

Re: Fwd: Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-06-25 Thread Jonathan Lu
Hi Masayoshi, On 06/22/2012 03:28 PM, Masayoshi Okutsu wrote: Hi Jonathan, You seem to have an assumption that the same number of chars (code units) means the same rendered text width. But that assumption is often not valid. I'd rather suggest use of locale-neutral formats, such as ISO 8601