Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Xueming Shen
On 6/22/12 11:02 AM, Mike Duigou wrote: On Jun 22 2012, at 10:01 , Xueming Shen wrote: Hi Here is the proposed change to support Unicode nfd/nfc and case insensitive file path on MacOSX file system. 7130915: File.equals does not give expected results when path contains Non-English characters

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Naoto Sato
Hi Sherman, There are several places where Locale.ENGLISH is used for locale neutral processing. You could instead use Locale.ROOT for that purpose. Naoto On 12/06/22 10:01, Xueming Shen wrote: Hi Here is the proposed change to support Unicode nfd/nfc and case insensitive file path on MacOS

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Mike Duigou
On Jun 22 2012, at 10:01 , Xueming Shen wrote: > Hi > > Here is the proposed change to support Unicode nfd/nfc and case insensitive > file path on MacOSX file system. > > 7130915: File.equals does not give expected results when path contains > Non-English characters on Mac OS X > 7168427: File

Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Xueming Shen
Hi Here is the proposed change to support Unicode nfd/nfc and case insensitive file path on MacOSX file system. 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X 7168427: FileInputStream cannot open file where the file path contains asian

Re: Fwd: Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale

2012-06-22 Thread Masayoshi Okutsu
Hi Jonathan, You seem to have an assumption that the same number of chars (code units) means the same rendered text width. But that assumption is often not valid. I'd rather suggest use of locale-neutral formats, such as ISO 8601 date-time formats. Thanks, Masayoshi On 6/20/2012 3:36 PM, Jo