Re: Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-11 Thread Yoshito Umaoka
Deven, If last time zone ID is cached along with the previously resolved index, and getZoneIndex does not check the contents of array, it might not work when zone strings are updated (setZoneStrings). So, to make this change work properly, you have to reset lastZoneID/zoneIndex in setZoneStri

Re: Performance patch for DateFormatSymbols.getZoneIndex(String)

2012-04-11 Thread Deven You
I think Yoshito's suggestion make sense, since the getZoneIndex is an internal method, if there is no manual setting to change the timezone, The timezone ID won't be changed for one instance of SimpleDateFormt. I updated the patch webrev[1] for this suggestion and test the GetZoneIndexTest.jav