Re: testcase failure java/util/Locale/Bug6989440.java

2011-10-09 Thread David Holmes
On 10/10/2011 1:35 PM, Naoto Sato wrote: Hi David, Thank you for your review. availableJRELocales is already declared with volatile keyword in the current source, so no change is involved. Sorry - my mistake. I misread something Chris posted earlier. Cheers, David Naoto On 10/9/11 6:22 PM,

Re: testcase failure java/util/Locale/Bug6989440.java

2011-10-09 Thread Naoto Sato
Hi David, Thank you for your review. availableJRELocales is already declared with volatile keyword in the current source, so no change is involved. Naoto On 10/9/11 6:22 PM, David Holmes wrote: Hi Naoto, This looks okay to me, but is missing the change to make availableJRELocales volatile (

Re: testcase failure java/util/Locale/Bug6989440.java

2011-10-09 Thread David Holmes
Hi Naoto, This looks okay to me, but is missing the change to make availableJRELocales volatile (which is needed to ensure safe publication) David On 8/10/2011 4:40 AM, Naoto Sato wrote: OK here is the proposed fix (including David's suggestion for using putIfAbsent). Can anyone please revie