Re: [html-formfu] PATCH for timezone support for H::F::Inflator::DateTime

2008-07-23 Thread Michele Beltrame
Hi Carl! > Also, the 'strptime' hashref gets passed to > DateTime::Format::Strptime->new(), which also accepts a 'time_zone' > argument. > Would it be a good idea to also pass along the inflator's 'time_zone', > if there's not one set in the 'strptime' arguments? I applied the patch (with tests+d

Re: [html-formfu] PATCH for timezone support for H::F::Inflator::DateTime

2008-07-21 Thread Michele Beltrame
Hi Carl! > And deprecating element_defaults() - meaning it'll issue a warning > that it'll be removed in a future release, and it'll just internally > do a hash-merge with defaults->{elements} > > Does that sound any better? This sounds great! Michele. -- Michele Beltrame http://www.cattlegri

Re: [html-formfu] PATCH for timezone support for H::F::Inflator::DateTime

2008-07-21 Thread Carl Franks
2008/7/17 Carl Franks <[EMAIL PROTECTED]>: > 2008/7/17 Moritz Onken <[EMAIL PROTECTED]>: >> Could you implement a default_time_zone config option? >> This would be really useful beacase you only have to set it once. > > Hm, I think we ought to supplement the element_defaults() method with > some ne

Re: [html-formfu] PATCH for timezone support for H::F::Inflator::DateTime

2008-07-17 Thread Carl Franks
2008/7/17 Moritz Onken <[EMAIL PROTECTED]>: > Could you implement a default_time_zone config option? > This would be really useful beacase you only have to set it once. Hm, I think we ought to supplement the element_defaults() method with some new ones: deflator_defaults() filter_defaults co

Re: [html-formfu] PATCH for timezone support for H::F::Inflator::DateTime

2008-07-17 Thread Carl Franks
2008/7/17 Michele Beltrame <[EMAIL PROTECTED]>: > Hello! > > I'm attaching a small patch which provides the ability to pass a > time_zone parameter to the DateTime inflator, in this fashion: > >inflators => [{ >type => 'DateTime', >time_zone => 'Europe/Helsinki', >

Re: [html-formfu] PATCH for timezone support for H::F::Inflator::DateTime

2008-07-17 Thread Moritz Onken
Could you implement a default_time_zone config option? This would be really useful beacase you only have to set it once. cheers, moritz Am 17.07.2008 um 16:36 schrieb Michele Beltrame: Hello! I'm attaching a small patch which provides the ability to pass a time_zone parameter to the DateTim