Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-28 Thread Steve Ebersole
After tweaking this, here is what I have... Manifest-Version: 1.0 Created-By: 1.8.0_121 (Oracle Corporation) Main-Class: org.hibernate.Version Specification-Title: hibernate-core Specification-Version: 5.3 Specification-Vendor: Hibernate.org Implementation-Title: hibernate-core Implementation-Ve

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-28 Thread Steve Ebersole
Gunnar, back to the original discussion... I asked you about this specifically in Paris and you responded "no" - but reading info I have found online seems to indicate that it is indeed perfectly valid to build with Java 9 and include a module-info.class into the jar and be able to load that into

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-28 Thread Steve Ebersole
Brett, after making these changes the osgi tests now fail[1] with a RMI connection error which I cannot decipher. Could you see if you can understand the problem? Thanks [1] http://ci.hibernate.org/job/hibernate-orm-master-h2-main/942/testReport/junit/org.hibernate.osgi.test/ On Thu, Dec 28, 2

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-28 Thread Gunnar Morling
Automatic-Module-Name looks good. While unrelated, those look odd: * Main-Class: I don't think ORM - as a library - should declare this * Specification-Title, Specification-Version: should these rather relate to JPA title and version (as opposed to the Implementation-* ones)? 2017-12-28 16:06 G

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-28 Thread Steve Ebersole
- Main-Class is fine afaik. It was requested previously by users and added accordingly. I'm not going to change it unless you can show me concrete reason to. - Specification-* - I had considered that. TBH its not important afaik. And Hibernate defines a specification as well (its

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-28 Thread Gunnar Morling
2017-12-28 19:10 GMT+01:00 Steve Ebersole : > >- Main-Class is fine afaik. It was requested previously by users and >added accordingly. I'm not going to change it unless you can show me >concrete reason to. > > Seeing now that Version indeed defines a main() method, didn't expect tha