Re: [hibernate-dev] Realising the JavaDoc jars as well

2017-12-23 Thread Sanne Grinovero
On 22 December 2017 at 18:16, Steve Ebersole wrote: > I wanted to get everyone's opinion about the api/spi/internal package > grouping we do in the aggregated Javadoc in regards to the per-module > javadocs. Adding this logic adds significant overhead to the process of > building the Javadoc, to

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-23 Thread Gunnar Morling
2017-12-22 23:07 GMT+01:00 Steve Ebersole : > I created a Jira to track this: https://hibernate. > atlassian.net/browse/HHH-12188 > > On Fri, Dec 22, 2017 at 5:33 AM Steve Ebersole > wrote: > >> Thanks for investigating this Gunnar. >> >> Some thoughts inline... >> >> On Wed, Dec 20, 2017 at 3:54

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-23 Thread Steve Ebersole
I already did a PR for the `Automatic-Module-Name` yesterday and added you as a reviewer. when you get a chance... On Sat, Dec 23, 2017 at 8:36 AM Gunnar Morling wrote: > 2017-12-22 23:07 GMT+01:00 Steve Ebersole : > >> I created a Jira to track this: >> https://hibernate.atlassian.net/browse

Re: [hibernate-dev] Using Hibernate ORM as automatic JPMS modules

2017-12-23 Thread Steve Ebersole
Another thing I was noticing was an annoying minor difference between the OSGi bundle name and the Java 9 module name: Automatic-Module-Name: org.hibernate.orm.core Bundle-SymbolicName: org.hibernate.core Does it make sense to adjust the OSGi bundle name to follow the module naming? On Sat, Dec