Re: [hibernate-dev] ManagedBeanRegistry - dependency injection support

2017-12-21 Thread Yoann Rodiere
Hi, Following our conversations on HipChat and the various changes you implemented (thanks!), I tested the current implementation. There were a few issues, but I managed to fix them and make all the tests in Hibernate Search pass. Here is a PR with the fixes: https://github.com/hibernate/hibernate

Re: [hibernate-dev] ManagedBeanRegistry - dependency injection support

2017-12-21 Thread Steve Ebersole
Awesome! Glad it worked out. However, I do think that there is still a need to expand the proposal Scott and I want to make to the CDI spec wrt something like our ExtendedBeanManager to also account for the shutdown phase. In addition to knowing when the BeanManager is ready to use, it would be

Re: [hibernate-dev] ManagedBeanRegistry - dependency injection support

2017-12-21 Thread Yoann Rodiere
> However, I do think that there is still a need to expand the proposal Scott and I want to make to the CDI spec wrt something like our ExtendedBeanManager to also account for the shutdown phase +1, I sent an email about just that on the mailing list. There are some drawbacks to this approach thou

Re: [hibernate-dev] ManagedBeanRegistry - dependency injection support

2017-12-21 Thread Steve Ebersole
Yep, I saw it. Just not sure I agree that this is not enough. On Thu, Dec 21, 2017 at 9:42 AM Yoann Rodiere wrote: > > However, I do think that there is still a need to expand the proposal > Scott and I want to make to the CDI spec wrt something like our > ExtendedBeanManager to also account fo

Re: [hibernate-dev] Locking German and French forums

2017-12-21 Thread Sanne Grinovero
+1 Thanks Vlad. On 21 December 2017 at 07:11, Vlad Mihalcea wrote: > Hi, > > I'm going to lock the German and French forums since users posts > question there from time to time, > and the questions remain answered. > > If someone has anything against it, let me know. Otherwise, we should use > th