[hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Mark Rotteveel
I'm still working on getting tests working for Firebird. One of the tests that fails is the documentation test org.hibernate.userguide.hql.HQLTest.test_hql_substring_function_example The reason this test fails is that Firebird hasn't implemented the SQL:2011 requirement that start positions low

Re: [hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Vlad Mihalcea
Hi Mark, Good catch. We should change it to 1, instead of 0. Vlad On Sat, Feb 11, 2017 at 4:28 PM, Mark Rotteveel wrote: > I'm still working on getting tests working for Firebird. > > One of the tests that fails is the documentation test > org.hibernate.userguide.hql.HQLTest.test_hql_substring

Re: [hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Mark Rotteveel
On 11-2-2017 15:56, Vlad Mihalcea wrote: > Hi Mark, > > Good catch. We should change it to 1, instead of 0. I created https://hibernate.atlassian.net/browse/HHH-11482, will post a PR later (hopefully this weekend). Mark -- Mark Rotteveel ___ hibernate

Re: [hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Vlad Mihalcea
Thanks a lot. Vlad On Sat, Feb 11, 2017 at 5:10 PM, Mark Rotteveel wrote: > On 11-2-2017 15:56, Vlad Mihalcea wrote: > >> Hi Mark, >> >> Good catch. We should change it to 1, instead of 0. >> > > I created https://hibernate.atlassian.net/browse/HHH-11482, will post a > PR later (hopefully this

Re: [hibernate-dev] SUBSTRING example in documentation uses start position 0 instead of 1.

2017-02-11 Thread Mark Rotteveel
On 11-2-2017 16:10, Mark Rotteveel wrote: > On 11-2-2017 15:56, Vlad Mihalcea wrote: >> Hi Mark, >> >> Good catch. We should change it to 1, instead of 0. > > I created https://hibernate.atlassian.net/browse/HHH-11482, will post a > PR later (hopefully this weekend). Pull request: https://github.c