Hi,
2016-10-27 4:27 GMT+02:00 Scott Marlow :
>
> > Unless I am mistaken, Gunnar is suggesting that the Hibernate ORM module
> (the WF module) export Javassist. Not the application.
>
Right, Hibernate ORM's module should be the one exposing it, not the
application nor JipiJapa.
This allows the
We could fix 1) as well by incorporating the sources for
jipijapa-hibernate52 in ORM.
I think it belongs within Hibernate, as it won't be the last time that a
new ORM version requires some adaptation of bootstrap.
On 27 Oct 2016 09:51, "Gunnar Morling" wrote:
> Hi,
>
> 2016-10-27 4:27 GMT+02:00
No, JPADependencyProcessor - which is adding the dependency - is part of
"wildfly-jpa", not "jipijapa-hibernate".
2016-10-27 11:23 GMT+02:00 Sanne Grinovero :
> We could fix 1) as well by incorporating the sources for
> jipijapa-hibernate52 in ORM.
>
> I think it belongs within Hibernate, as it w
Ok well that's also odd isn't it?
On 27 Oct 2016 10:38, "Gunnar Morling" wrote:
> No, JPADependencyProcessor - which is adding the dependency - is part of
> "wildfly-jpa", not "jipijapa-hibernate".
>
> 2016-10-27 11:23 GMT+02:00 Sanne Grinovero :
>
>> We could fix 1) as well by incorporating the
JPADependencyProcessor deals with adding JPA dependencies generally (i.e.
it works for whatever JPA provider is configured), so it seems reasonable
by itself.
But as said shouldn't be adding the dependency to Javassist as that's
better left to the module(s) of the specific provider(s) needing it.
Only a WildFly deployment unit processor (DUP) can add dependencies to
an application deployment. Jipijapa is not a DUP.
On Thu, Oct 27, 2016 at 6:12 AM, Sanne Grinovero wrote:
> Ok well that's also odd isn't it?
>
>
> On 27 Oct 2016 10:38, "Gunnar Morling" wrote:
>>
>> No, JPADependencyProcess
On Thu, Oct 27, 2016 at 4:49 AM, Gunnar Morling wrote:
> Hi,
Hi,
>
> 2016-10-27 4:27 GMT+02:00 Scott Marlow :
>>
>>
>> > Unless I am mistaken, Gunnar is suggesting that the Hibernate ORM module
>> > (the WF module) export Javassist. Not the application.
>
>
> Right, Hibernate ORM's module shoul
On 27 October 2016 at 13:38, Scott Marlow wrote:
> Only a WildFly deployment unit processor (DUP) can add dependencies to
> an application deployment. Jipijapa is not a DUP.
Ah, thanks Scott that helps to understand this all.
Still, I agree with Gunnar that any additional dependencies belong in
2016-10-27 14:59 GMT+02:00 Scott Marlow :
> On Thu, Oct 27, 2016 at 4:49 AM, Gunnar Morling
> wrote:
> > Hi,
>
> Hi,
>
> >
> > 2016-10-27 4:27 GMT+02:00 Scott Marlow :
> >>
> >>
> >> > Unless I am mistaken, Gunnar is suggesting that the Hibernate ORM
> module
> >> > (the WF module) export Javassi
I remember now why I didn't remove the JPADependencyProcessor
injection of Javassist in
https://github.com/wildfly/wildfly/pull/8474, it would cause a failure
in applications that embeds a copy of the ORM jars but the application
doesn't have the Javassisst jars on its classpath. Currently,
JPADep
I would argue that that is a bad deployment. IMO if you supply your own
Hibernate jars, you'd be responsible for supplying its dependency jars as
well. Javassist is currently a non-optional dependency of ORM.
On Thu, Oct 27, 2016 at 8:55 AM Scott Marlow wrote:
> I remember now why I didn't rem
We can call it a bad deployment, however, at the same time, we don't
want to break application compatibility in a way that requires the
application to be cracked open and modified (even if the fix is just a
simple MANIFEST.MF change).
On Thu, Oct 27, 2016 at 10:07 AM, Steve Ebersole wrote:
> I wo
Dunno. To me this is a bug that Jipijapa/WF/DUP adds this dependency at
all. How that gets resolved or not is completely up to Jipijapa/WF/DUP as
it is the one(s) doing this. There is nothing Hibernate can do here.
On Thu, Oct 27, 2016 at 9:11 AM Scott Marlow wrote:
> We can call it a bad de
2016-10-27 15:55 GMT+02:00 Scott Marlow :
> I remember now why I didn't remove the JPADependencyProcessor
> injection of Javassist in
> https://github.com/wildfly/wildfly/pull/8474, it would cause a failure
> in applications that embeds a copy of the ORM jars but the application
> doesn't have the
On Thu, Oct 27, 2016 at 10:09 AM, Gunnar Morling wrote:
> 2016-10-27 15:55 GMT+02:00 Scott Marlow :
>>
>> I remember now why I didn't remove the JPADependencyProcessor
>> injection of Javassist in
>> https://github.com/wildfly/wildfly/pull/8474, it would cause a failure
>> in applications that emb
Hi,
I'm pleased to announce the first maintenance release of Hibernate
Validator 5.3.
For more information, please see the full announcement here:
http://in.relation.to/2016/10/27/hibernate-validator-531-final-out/ .
Have a nice day!
--
Guillaume
___
I updated https://github.com/wildfly/wildfly/pull/8474 to make a push
for applying the pull request and also mentioned the desire to update
JPADependencyProcessor to not inject Javassist into applications.
Perhaps others from the WildFly team will disagree with me and make an
exception to break app
On Thu, Oct 27, 2016 at 10:14 AM, Steve Ebersole wrote:
> Dunno. To me this is a bug that Jipijapa/WF/DUP adds this dependency at
> all. How that gets resolved or not is completely up to Jipijapa/WF/DUP as
> it is the one(s) doing this. There is nothing Hibernate can do here.
>
>
I updated the
18 matches
Mail list logo
