I'm working on improving support for Firebird in Hibernate, and I have
run into a problem where
org.hibernate.tool.schema.internal.SchemaCreatorImpl is always trying to
create a pooled sequence.
Specifically:
applySqlStrings(
dialect.getCreateSequenceStrings(
jdbcEnvironment.getQual
Hi Mark,
I've just run the PooledHiLoSequenceIdentifierTest test after modifying the
TABLE to SEQUENCE to see how it works and this is what I found:
1. SchemaCreatorImpl calls String[] getCreateSequenceStrings(String
sequenceName, int initialValue, int incrementSize)
2. The String getCreateSequen
On 28-7-2016 12:22, Vlad Mihalcea wrote:
> Hi Mark,
>
> I've just run the PooledHiLoSequenceIdentifierTest test after modifying
> the TABLE to SEQUENCE to see how it works and this is what I found:
>
> 1. SchemaCreatorImpl calls String[] getCreateSequenceStrings(String
> sequenceName, int initialVa
Is it that you get the exception even if the incrementSize is 1? I guess
this is an issue that we need to open a Jira ticket for it.
On Thu, Jul 28, 2016 at 1:57 PM, Mark Rotteveel
wrote:
> On 28-7-2016 12:22, Vlad Mihalcea wrote:
>
>> Hi Mark,
>>
>> I've just run the PooledHiLoSequenceIdentifie
On 28-7-2016 13:02, Vlad Mihalcea wrote:
> Is it that you get the exception even if the incrementSize is 1? I guess
> this is an issue that we need to open a Jira ticket for it.
Yes, see the code in my initial email: SchemaCreatorImpl always tries to
create a pooled sequence.
Mark
--
Mark Rotte
Hi Flemming,
I agree on the importance to have some runnable examples, but I'm
afraid that the "demos" repository wouldn't be kept up to date with
every single release.
Introducing more tasks to perform during a release is not desirable,
as the release process is quite complex already.
So I propo
I do think this is an error. I think the proper fix is to first make use
of Exporter#getSqlCreateStrings via Dialect#getSequenceExporter.
>From there, either:
1. Change the standard Exporter to look at
Dialect#supportsPooledSequences and deciding which
Dialect#getCreateSequenceStrings f
> Secondary aspect: let's assume we had good enough integration tests in
> OGM. Should we advertise these more prominently in documentation?
I don't think we should, an integration test is different from an example.
I'm afraid will be harder for people to recognize what it is required
and what it
