[hibernate-dev] [Search] ElasticSearch - Progress on faceting

2016-02-04 Thread Guillaume Smet
Hi, So the good news: most of the faceting tests now pass with ES. I rebased the patch onto master. https://github.com/gsmet/hibernate-search/commits/elastic-facet2 and for now only one commit: https://github.com/gsmet/hibernate-search/commit/657ecfe684e6b4e952d11274523a4c5683e0c7eb It's not a

Re: [hibernate-dev] [Search] ElasticSearch - Progress on faceting

2016-02-04 Thread Gunnar Morling
Hi Guillaume, Awesome, great to see you making progress here! I need to take a closer look, but some quick comments inline. @Sanne, this reminds me of that pending PR of mine; Any chance you spend some cycles reviewing and merging it? Guillaume's work is based on it and it'll also serve as base o

Re: [hibernate-dev] [Search] ElasticSearch - Progress on faceting

2016-02-04 Thread Hardy Ferentschik
Hi Guillaume, Awesome to see so much activity, especially in an area which I used to work on so much. I think it is great that we get some more eyes on the code now. What you say makes sense from a birds eye perspective. I am hoping that I will find some time soon to have a closer look at your su