I love Steve's idea of having a dedicated implementation for
non-multitenant users.
But +1 to also apply this improvement.
Sanne
On 14 December 2015 at 01:44, Stuart Douglas wrote:
>
>
> - Original Message -
>> From: "Scott Marlow"
>> To: "Stuart Douglas" , hibernate-dev@lists.jboss.or
Hi all,
while reviewing an improvement by Stale about reducing
synchronization, I'm having the impression that the synchronization
could be completely removed.
But there's a comment warning me against that, so for sake of safety
I'm merging the improvement without risking going too far:
// synch
Hi,
We really need to test it thoroughly because the current pooled optimizer
are reasonably fast especially when used with a database sequence.
The table generators are slow because of the row-level locking, so I won't
include those in this discussion.
What strikes me is the synchronized block w
Hello all,
while creating the basic scaffolding for the new GridDialect, I
called the new Maven module "hibernate-ogm-infinispan-hotrod". Which
is rather long, but descriptive.
Q1: any better name?
The current one which we have working on Infinispan "embedded mode"
is named "hibernate-ogm-
I would use:
hibernate-ogm-infinispan-hotrod
For Neo4j we have a similart problem
at the moment the directory is hibernate-ogm-neo4j and the short name is
'neo4j_embedded'
Whatever we choose I guess we should be consistent:
I guess haivng
- hibernate-ogm-infinispan/embedded
- hibernate-ogm-infin
Does it have to be a separate module to begin with?
For MongoDB - which contains two datastore providers (MongoDB, Fongo)
and Redis - which also will have two different dialects as per Mark's
pending PR - it's one module.
We should stick to one pattern, and having one module seems easier on
the u
Sorry for the previous email, I've sent it too soon pressing some strange
keywords combination.
> We should stick to one pattern, and having one module seems easier on
> the user to me. So unless you see a strong advantage for two modules
> I'd say let's use one.
One general disadvantage I can se
On 14 December 2015 at 18:09, Gunnar Morling wrote:
> Does it have to be a separate module to begin with?
>
> For MongoDB - which contains two datastore providers (MongoDB, Fongo)
> and Redis - which also will have two different dialects as per Mark's
> pending PR - it's one module.
>
> We should
On 14 December 2015 at 17:10, Vlad Mihalcea wrote:
> Hi,
>
> We really need to test it thoroughly because the current pooled optimizer
> are reasonably fast especially when used with a database sequence.
> The table generators are slow because of the row-level locking, so I won't
> include those i
Sanne, you just described the general approach of "short naming" for config
options overall :)
On Mon, Dec 14, 2015 at 6:28 PM Sanne Grinovero wrote:
> On 14 December 2015 at 17:10, Vlad Mihalcea
> wrote:
> > Hi,
> >
> > We really need to test it thoroughly because the current pooled optimize
Hi, we've done some runs now with 5.0.6-SNAPSHOT (built today) and we're
seeing a lot more contention compared to the same build without Stuart's
patch.
If possible I would like to see this being merged, but if it's not
possible Steve's suggestion should also work afaik.
ståle
On 14.12.15 15:1
It's very possible that code comments may no longer be pertinent.
On Mon, Dec 14, 2015 at 10:26 AM Sanne Grinovero
wrote:
> Hi all,
> while reviewing an improvement by Stale about reducing
> synchronization, I'm having the impression that the synchronization
> could be completely removed.
>
> Bu
I'm confused. Sanne was talking about a completely different piece of code
from optimizers. Maybe you are mixing this and the other current
hibernate-dev discussion?
On Mon, Dec 14, 2015 at 11:10 AM Vlad Mihalcea
wrote:
> Hi,
>
> We really need to test it thoroughly because the current pooled
On 12/13/2015 08:44 PM, Stuart Douglas wrote:
>
>
> - Original Message -
>> From: "Scott Marlow"
>> To: "Stuart Douglas" , hibernate-dev@lists.jboss.org
>> Sent: Friday, 11 December, 2015 10:54:15 PM
>> Subject: Re: [hibernate-dev] Pooled Optimiser Improvements
>>
>> Should this be a spe
On 12/11/2015 09:30 AM, Steve Ebersole wrote:
> It's hard to say without understanding the scenario where you are seeing
> this as a problem. I have some guesses as to what may be the problem,
> but without understanding more about why you see this as a problem in
> the first place it is hard to
Hi,
Sorry for the confusion, I mistakenly replied on a different thread.
Vlad
On Tue, Dec 15, 2015 at 3:48 AM, Steve Ebersole wrote:
> I'm confused. Sanne was talking about a completely different piece of
> code from optimizers. Maybe you are mixing this and the other current
> hibernate-dev
16 matches
Mail list logo