Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: > Hardy, > > It seems that the ValidatorFactoryBean#createConstraintValidatorFactory is > getting called too late for some reason. http://pastebin.com/WrdD91Hr shows > the call stack for > ValidatorFactoryBean#create(CreationalContext c

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Sanne Grinovero
On 8 July 2015 at 11:42, Hardy Ferentschik wrote: > On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: >> Hardy, >> >> It seems that the ValidatorFactoryBean#createConstraintValidatorFactory is >> getting called too late for some reason. http://pastebin.com/WrdD91Hr shows >> the call st

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: > To recreate the WildFly ORM 5 issue on WildFly (if you want to see it > yourself), steps are: For the record, I see the same test failures locally. I have not looked any further regarding their cause. @Scott, on a high level what are

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 07:15 AM, Sanne Grinovero wrote: > On 8 July 2015 at 11:42, Hardy Ferentschik wrote: >> On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: >>> Hardy, >>> >>> It seems that the ValidatorFactoryBean#createConstraintValidatorFactory is >>> getting called too late for some r

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 08:16 AM, Hardy Ferentschik wrote: > On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: >> To recreate the WildFly ORM 5 issue on WildFly (if you want to see it >> yourself), steps are: > > For the record, I see the same test failures locally. I have not looked any > furt

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Gunnar Morling
Scott, could you update the Gist with the complete stack trace you got? It seems to only contains parts of it. 2015-07-08 14:32 GMT+02:00 Scott Marlow : > > > On 07/08/2015 08:16 AM, Hardy Ferentschik wrote: > > On Tue, Jul 07, 2015 at 04:50:36PM -0400, Scott Marlow wrote: > >> To recreate the Wi

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
Here are a few different call stacks: 1. http://pastebin.com/ZiZL5vEh shows the call stack when running against the WildFly master branch (with ORM 4.3.x) and the @Inject works (the test org.jboss.as.test.integration.jpa.beanvalidation.cdi.CustomMinValidator.setMinimumValueProvider() method

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
Hi, > The same test works with the WildFly master branch, which is using ORM > 4.3.x. The Bean Validation integration code is unchanged in my WildFly > branch, as is the Bean Validator. The only thing different, is the ORM 5 > integration code and the ORM 5 persistence provider. Just fishing he

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 09:02 AM, Hardy Ferentschik wrote: > Hi, > >> The same test works with the WildFly master branch, which is using ORM >> 4.3.x. The Bean Validation integration code is unchanged in my WildFly >> branch, as is the Bean Validator. The only thing different, is the ORM 5 >> integration

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 09:02 AM, Hardy Ferentschik wrote: > Hi, > >> The same test works with the WildFly master branch, which is using ORM >> 4.3.x. The Bean Validation integration code is unchanged in my WildFly >> branch, as is the Bean Validator. The only thing different, is the ORM 5 >> integration

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
On Wed, Jul 08, 2015 at 09:11:55AM -0400, Scott Marlow wrote: > >Just fishing here, but "integration code and the ORM 5 persistence provider" > >might > >indicate a problem in the persistence bootstrapping. > >Have a look at > >org.hibernate.cfg.beanvalidation.TypeSafeActivator#getValidatorFactor

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl#populate(SessionFactoryBuilder sfBuilder, StandardServiceRegistry ssr) does pass the correct VF to sfBuilder.applyValidatorFactory (using the ValidatorFactory passed to the EntityManagerFactoryBuilderImpl.withValidatorFactory). Ho

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
On 07/08/2015 09:32 AM, Hardy Ferentschik wrote: > On Wed, Jul 08, 2015 at 09:11:55AM -0400, Scott Marlow wrote: >>> Just fishing here, but "integration code and the ORM 5 persistence >>> provider" might >>> indicate a problem in the persistence bootstrapping. >>> Have a look at >>> org.hiberna

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Hardy Ferentschik
Hi, > http://pastebin.com/4X0h1VPA is the call stack in. We are in the second > bootstrap phase, which is good. The validator factory is passed into the > integration properties but we are only checking the persistence unit > properties in ORM 5. Since we are not looking in the integration pro

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Scott Marlow
Steve, I created HHH-9905 for this, which I was able to workaround with a quick hack (set the missing "javax.persistence.validation.factory" property in the ConfigurationService). I was able to pass the WildFly test with the workaround. Steve, is that the right fix? I assigned the jira to yo

Re: [hibernate-dev] WildFly BeanValidationCdiIntegrationTestCase test failure with ORM 5

2015-07-08 Thread Steve Ebersole
Looks like I missed a small piece there. The intention was to have TypeSafeActivator pick up SessionFactoryOptions#getValidatorFactoryReference. Scott, can you make sure SessionFactoryOptions#getValidatorFactoryReference contains the proper ValidatorFactory reference when we get into TypeSafeActi

Re: [hibernate-dev] SOAP / XML-RPC from JIRA is going dark on the 20th

2015-07-08 Thread Steve Ebersole
I would assume part of that is the Atlassian Connector for IntelliJ that I use. Which sucks because now I would have to use the non-community version of the IDE to use tasks stuff. Out of curiosity, how does everyone else using IntelliJ connect it to Jira or do y'all not connect it at all? On Tu

[hibernate-dev] Starting 5.0.0 CR2 release

2015-07-08 Thread Steve Ebersole
Please no more pushing to master until I am done. Thanks ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Starting 5.0.0 CR2 release

2015-07-08 Thread Steve Ebersole
Ok, I am done with the release. I am still writing up the announcement in the new blog system; the information is here too: https://github.com/hibernate/hibernate-orm/releases/tag/5.0.0.CR2 On Wed, Jul 8, 2015 at 11:18 AM Steve Ebersole wrote: > Please no more pushing to master until I am done.

[hibernate-dev] Second candidate release for Hibernate ORM 5.0

2015-07-08 Thread Steve Ebersole
Hibernate ORM 5.0.0.CR2 has just been released. Details can be found at https://github.com/hibernate/hibernate-orm/releases/tag/5.0.0.CR2 * - I ran into problems getting the new blog site to work for me, so pointed here to the GitHub release comment ___

Re: [hibernate-dev] Second candidate release for Hibernate ORM 5.0

2015-07-08 Thread Steve Ebersole
As I said, I had trouble writing this blog in the new asciidoctor stuff. I had some trouble getting ruby etal set up locally. Sanne had mentioned that I could just push to staging branch and CI would automatically build it for me and I could check it that way. Well the CI job clearly saw my chan

Re: [hibernate-dev] Second candidate release for Hibernate ORM 5.0

2015-07-08 Thread Steve Ebersole
Wow, now it shows up. Like almost an hour later. On Wed, Jul 8, 2015 at 2:17 PM Steve Ebersole wrote: > As I said, I had trouble writing this blog in the new asciidoctor stuff. > I had some trouble getting ruby etal set up locally. Sanne had mentioned > that I could just push to staging branch

[hibernate-dev] WildFly error running org.jboss.as.test.integration.jpa.hibernate.classfiletransformertest.ClassFileTransformerTestCase (sets hibernate.ejb.use_class_enhancer to true)

2015-07-08 Thread Scott Marlow
We are getting a "Failed to define class org.jboss.as.test.integration.jpa.hibernate.SFSBHibernateSessionFactory" error when running the WildFly tests on the CI machine. I don't see this error locally which is why we didn't see this before. [1] shows the WildFly console at the time of error.

Re: [hibernate-dev] Second candidate release for Hibernate ORM 5.0

2015-07-08 Thread Hardy Ferentschik
Hi, On Wed, Jul 08, 2015 at 07:17:07PM +, Steve Ebersole wrote: > As I said, I had trouble writing this blog in the new asciidoctor stuff. I > had some trouble getting ruby etal set up locally Can you provide any more info than that? I am happy to help you setting this up, but I need some m

Re: [hibernate-dev] Second candidate release for Hibernate ORM 5.0

2015-07-08 Thread Hardy Ferentschik
> As I said, I had trouble writing this blog in the new asciidoctor stuff. I > had some trouble getting ruby etal set up locally. Sanne had mentioned > that I could just push to staging branch and CI would automatically build > it for me and I could check it that way. Well the CI job clearly saw

Re: [hibernate-dev] WildFly error running org.jboss.as.test.integration.jpa.hibernate.classfiletransformertest.ClassFileTransformerTestCase (sets hibernate.ejb.use_class_enhancer to true)

2015-07-08 Thread Scott Marlow
I noticed that CI test failure is only occurring on Windows. I wonder if https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/bytecode/enhance/spi/Enhancer.java#L114 is misbehaving on Windows. On 07/08/2015 04:00 PM, Scott Marlow wrote: > We are ge

Re: [hibernate-dev] WildFly error running org.jboss.as.test.integration.jpa.hibernate.classfiletransformertest.ClassFileTransformerTestCase (sets hibernate.ejb.use_class_enhancer to true)

2015-07-08 Thread Scott Marlow
On 07/08/2015 07:00 PM, Scott Marlow wrote: > I noticed that CI test failure is only occurring on Windows. I wonder > if > https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/bytecode/enhance/spi/Enhancer.java#L114 > is misbehaving on Windows. We mi

Re: [hibernate-dev] WildFly error running org.jboss.as.test.integration.jpa.hibernate.classfiletransformertest.ClassFileTransformerTestCase (sets hibernate.ejb.use_class_enhancer to true)

2015-07-08 Thread Luis Barreiro
I did review the code and come up with the same conclusion. Issue: https://hibernate.atlassian.net/browse/HHH-9907 PR open: https://github.com/hibernate/hibernate-orm/pull/996 Regards, On 07/09/2015 02:03 AM, Scott Marlow wrote: > > On 07/08/2015 07:00 PM, Scott Marlow wrote: >> I noticed that