Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17

2015-01-06 Thread Gail Badner
I've finished building and taggind for 4.2.17.Final. I'm getting some final fixes in for 4.3.8.Final, then I'll release that version. I'll finish these up on Tuesday. Gail - Original Message - > From: "Gail Badner" > To: "hibernate-dev" > Sent: Monday, January 5, 2015 1:10:08 PM > Subj

Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17

2015-01-06 Thread Petar Tahchiev
Any chance to get this included https://github.com/hibernate/hibernate-orm/pull/863 ? 2015-01-06 10:37 GMT+02:00 Gail Badner : > I've finished building and taggind for 4.2.17.Final. I'm getting some > final fixes in for 4.3.8.Final, then I'll release that version. I'll finish > these up on Tuesd

Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17

2015-01-06 Thread Gail Badner
Hi Peter, It looks like your pull request changed tabs to spaces, so there are a lot of diffs. I can't tell what exactly you changed. Please recreate the pull request without changing tabs to spaces. I'm sorry, this will not make it into 4.3.8. I'll consider it for 4.3.9. Regards, Gail -

Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17

2015-01-06 Thread Petar Tahchiev
Hi Gail, can you point me to the Hibernate code formatter file (for eclipse or intellij idea)? I'm trying to find it but i cannot. 2015-01-06 11:00 GMT+02:00 Gail Badner : > Hi Peter, > > It looks like your pull request changed tabs to spaces, so there are a lot > of diffs. I can't tell what exa

Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17

2015-01-06 Thread Sanne Grinovero
Hi Petar, we have different instructions for Eclipse or IntelliJ users; here you should find general contribution guidelines and also the code styles attached: - https://developer.jboss.org/wiki/ContributingToHibernateUsingEclipse - https://developer.jboss.org/wiki/ContributingToHibernateUsingInt

Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17

2015-01-06 Thread Petar Tahchiev
Thank you all, I'm using now the codestyles that were attached in the wiki and this time I think it looks better. Here's the new pull-request https://github.com/hibernate/hibernate-orm/pull/864 and I have also signed the CLA. My changes are really simple - I have added 2 new methods with delegat

[hibernate-dev] Hibernate ORM 4.3.8.Final and 4.2.17.Final Released

2015-01-06 Thread Gail Badner
For details, see http://in.relation.to/Bloggers/HibernateORM438FinalAnd4217FinalReleased. Gail Badner Red Hat, Hibernate ORM ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev