[hibernate-dev] Redefining the API/SPI/implementation split

2014-12-05 Thread Sanne Grinovero
One of today's issues for Hibernate Search had the goal to move this class: org.hibernate.search.engine.spi.SearchFactoryImplementor to not have the "SPI" package postfix as we never meant this to be part of the SPI but rather an internal contract. While it's an internal contract, it's functional

Re: [hibernate-dev] Redefining the API/SPI/implementation split

2014-12-05 Thread Emmanuel Bernard
If hibernate-search-orm needs it, it's likely that infinispan-query could also make use of that contract. After all, infinispan-query is very similar conceptually to our ORM integration albeit simpler. Isn't it our definition of a SPI? If you don't change your mind, I am not a big fan of the inte

Re: [hibernate-dev] Redefining the API/SPI/implementation split

2014-12-05 Thread Sanne Grinovero
Thanks for the quick feedback! On 5 December 2014 at 21:35, Emmanuel Bernard wrote: > If hibernate-search-orm needs it, it's likely that infinispan-query > could also make use of that contract. After all, infinispan-query is > very similar conceptually to our ORM integration albeit simpler. I ha