Re: [hibernate-dev] Source links in JIRA broken

2011-09-26 Thread Steve Ebersole
Yeah I am aware. I have been working with Atlassian/Contegix to get that working again. On Sun 25 Sep 2011 12:32:41 PM CDT, Gunnar Morling wrote: > Hi, > > I just noticed that the connection between JIRA issues and the > associated sources in FishEye/GitHub seems to be broken. > > Taking HHH-593

[hibernate-dev] HHH-6677 skip @BeforeClassOnce / @AfterClassOnce if test is ignored

2011-09-26 Thread Strong Liu
https://hibernate.onjira.com/browse/HHH-6677 I don't find a elegant way to fix this…. one option is in org.hibernate.testing.junit4.CustomRunner#withBeforeClasses, we check if the test class has @Skip (and @RequiresDialect etc.), and if it does, then return super.withBeforeClasses directly (i kn

[hibernate-dev] ServiceRegistry naming

2011-09-26 Thread Steve Ebersole
Currently we utilize 3 different ServiceRegistry types within Hibernate and I wanted to hopefully get some consensus on their names. 1) org.hibernate.service.internal.BootstrapServiceRegistryImpl. It contains services that have to be known up front. Currently this is limited to ClassLoaderSer

Re: [hibernate-dev] HHH-6677 skip @BeforeClassOnce / @AfterClassOnce if test is ignored

2011-09-26 Thread Steve Ebersole
Essentially you want to skip processing @BeforeClassOnce / @AfterClassOnce if there are no test methods to execute for said class being processed. I think you should be able to call org.hibernate.testing.junit4.CustomRunner#computeTestMethods to accomplish this. If computeTestMethods returns

Re: [hibernate-dev] HHH-6677 skip @BeforeClassOnce / @AfterClassOnce if test is ignored

2011-09-26 Thread Strong Liu
On Sep 26, 2011, at 11:47 PM, Steve Ebersole wrote: > Essentially you want to skip processing @BeforeClassOnce / @AfterClassOnce if > there are no test methods to execute for said class being processed. > Ideally, we should skip processing @BeforeClassOnce / @AfterClassOnce and @BeforeClass /

Re: [hibernate-dev] ServiceRegistry naming

2011-09-26 Thread Emmanuel Bernard
For 2, The hard part is to understand when a given registry is used and for what purpose. In a way Basic, Main, Core, Generic (the alternate names I can think of) are not telling very much. The Basic registry holds services that are used at most stages of Hibernate. Would Global make any sens

Re: [hibernate-dev] HHH-6677 skip @BeforeClassOnce / @AfterClassOnce if test is ignored

2011-09-26 Thread Steve Ebersole
>> Essentially you want to skip processing @BeforeClassOnce / @AfterClassOnce >> if there are no test methods to execute for said class being processed. >> > > Ideally, we should skip processing @BeforeClassOnce / @AfterClassOnce and > @BeforeClass / @AfterClass but for now skipping these two Onc

Re: [hibernate-dev] ServiceRegistry naming

2011-09-26 Thread Steve Ebersole
On Mon 26 Sep 2011 11:09:56 AM CDT, Emmanuel Bernard wrote: > For 2, > The hard part is to understand when a given registry is used and for what > purpose. Not sure I understand what you mean here. Used in what way? For lookups? Well the lookups are hierarchical. Thats not an issue at all