I've submitted the pull request (
https://github.com/hibernate/hibernate-core/pull/8) for master. I should
have it also ready for 3.6 branch as soon as I manage to merge the change
between branches in this git thng that is pretty new to me ;)
On Tue, Nov 2, 2010 at 1:18 PM, Emmanuel Bernard wrote:
Uncertain yet of how these pull request comments work on GitHub, so I thought
I'll make sure and respond here. The change should use
org.hibernate.mapping.PersistentClass#getEntityName instead of
org.hibernate.mapping.PersistentClass#getNodeName.
See my other email to the dev list about portin
Hi Steve,
PersistentClass#getEntityName is not good, because it is exactly the same
value as PersistentClass#getClassName.
PersistentClass#getClassName is populated in
org.hibernate.cfg.annotations.EntityBinder#bindEntity with the value from
org.hibernate.annotations.common.reflection.java.JavaXCl
If that is really the case, then that is a problem with the annotation binding
code.
On Wednesday, November 03, 2010, at 06:50 am, Tomasz Blachowicz wrote:
> Hi Steve,
>
> PersistentClass#getEntityName is not good, because it is exactly the same
> value as PersistentClass#getClassName.
> Persist
Ah, I misread. I thought you meant the Hibernate notion of an "entity name".
As far as I can tell now looking at it, there is no such annotation equiv for
that.
@javax.persistence.Entity.name is really more akin to Hibernate's notion of an
import name for queries.
I am not really understan
I think I understand what you mean. "Node name" might not be indeed the best
way to do that.
I think implementation of the EntityBinder with regards to the handling of
@Entity.name is correct. My understanding of the jsr-317 is that the entity
name used in queries should be @Entity.name if specifi
You can have a look at my pull request to see exaclty what I mean.
https://github.com/hibernate/hibernate-core/pull/9 (two commits form that
branch)
On Wed, Nov 3, 2010 at 1:54 PM, Tomasz Blachowicz wrote:
> I think I understand what you mean. "Node name" might not be indeed the
> best way to do
We were just discussing this on IRC. Yes I think adding a new attribute to
PersistentClass to capture the value of @Entity.name specifically (really we'd
just populate it with EntityBinder.name) is best.
So we know *how* to do it. But to be honest, I am still uncertain whether we
*should* do
It's up to you. I put my arguments in the ticket. I agree that jsr317 spec
does not specify the correlation of the @Entity.name and
EntityType#getName(), but I do think it if reasonable to think that entity
name returned by the meta model and the entity name specified in the
annotation is the same
I completely empathize since the JPA "metamodel" defines no other means to get
at this information. I am however nervous especially nervous about
backporting this fix as it is a change in behavior that is far from clearly a
bug. I am kind of new to annotations so it is hard for me to say how/i
Steve, I think I know where you coming from. And my request is to do it
*only* in the context of JPA meta-model. I'm far from making any changes to
the internals of Hibernate.
My pain point is that if EntityType is not providing me with the
@Entity.name I don't have any other means of getting that
If OpenJPA and EclipseLink went this way it makes sense to align. At least
for Hibernate 4.
I am also undecided whether to backport the issue or not. I tend rather
towards no, but without
any strong argument.
Whether and how EntityType.getName() is getting used I don't know.
Generally I woul
On Wednesday, November 03, 2010, at 11:33 am, Tomasz Blachowicz wrote:
> Steve, I think I know where you coming from. And my request is to do it
> *only* in the context of JPA meta-model. I'm far from making any changes to
> the internals of Hibernate.
> My pain point is that if EntityType is not p
Steve, I do believe we are on the same page and there is no disagreement at
all. I think you understand my argument clearly and I do understand your
concerns regarding users.
On Wed, Nov 3, 2010 at 4:49 PM, Steve Ebersole wrote:
> On Wednesday, November 03, 2010, at 11:33 am, Tomasz Blachowicz w
Changing behaviors would be a good way to gauge that from the number of JIRA
issues created ;)
On Wednesday, November 03, 2010, at 10:36 am, Hardy Ferentschik wrote:
> If OpenJPA and EclipseLink went this way it makes sense to align. At least
> for Hibernate 4.
> I am also undecided whether to ba
15 matches
Mail list logo
