Re: [hibernate-dev] Help with first patch

2009-06-17 Thread Juraci Paixao Krohling
Em 16-06-2009 23:32, Nikolas Everett escreveu: That failed because I'm on Java 1.6 and there are JDBC incompatibilities. I'm not sure how I'd have known that other than the comment at the bottom of https://www.hibernate.org/422.html . So I installed Java 1.5 and tried again: JAVA_HOME=/usr/lib

Re: [hibernate-dev] Help with first patch

2009-06-17 Thread Nikolas Everett
> > >> That failed in testsuite with: >> Failed tests: >> testProxyReuse(org.hibernate.test.legacy.ParentChildTest) >> >> >> testPaginationWithPolymorphicQuery(org.hibernate.test.hql.ASTParserLoadingTest) >> testMultipleBagFetchesFail(org.hibernate.test.hql.ASTParserLoadingTest) >> testDuplic

Re: [hibernate-dev] Help with first patch

2009-06-17 Thread Juraci Paixao Krohling
Em 17-06-2009 14:53, Nikolas Everett escreveu: Are these expected errors, then? Not really. Expected failures have its method name ending in FailureExpected, and are marked as "PASS" if they fail. I would say that these are the failures which should be addressed, but aren't yet. I have ano

RE: [hibernate-dev] HHH 869 (Collections of value type in the Criteria API).

2009-06-17 Thread David Mansfield
[previously sent out from wrong account and it didn't make the list] On Tue, 2009-06-09 at 21:34 -0500, Steve Ebersole wrote: > On Tue, 2009-06-09 at 18:18 -0700, Daniel Pitts wrote: > > > That makes sense. If I submit a patch that basically refactors the CQT > > class, what might be considered

Re: [hibernate-dev] HHH 869 (Collections of value type in the Criteria API).

2009-06-17 Thread Donnchadh Ó Donnabháin
You should probably attach it to the JIRA issue ( http://opensource.atlassian.com/projects/hibernate/browse/HHH-869 ) . Also the patch seems incomplete in that there appear to be no JUnit test cases included. Donnchadh 2009/6/17 David Mansfield : > [previously sent out from wrong account and it

Re: [hibernate-dev] Help with first patch

2009-06-17 Thread Nikolas Everett
> > I have another question. The particular bug I wrote a patch for only >> comes up with MySQL. Is there some way to test hibernate against >> > > Yes. On Hibernate Core, you can override the appliesTo(Dialect) method and > return "true" for MySQL-based dialects and false for the others. If I

Re: [hibernate-dev] HHH 869 (Collections of value type in the Criteria API).

2009-06-17 Thread David Mansfield
Hi, I'm not going to do the JUnit stuff until I get a commitment that my work won't be wasted. Last I heard, the CriteriaQueryTranslator was going away and therefore the problem would be fixed by building AST trees so that the queries execute the same way HQL does. If this is indeed the case, th

Re: [hibernate-dev] HHH 869 (Collections of value type in the Criteria API).

2009-06-17 Thread Steve Ebersole
On Wed, 2009-06-17 at 10:52 -0400, David Mansfield wrote: > Hi, > > I'm not going to do the JUnit stuff until I get a commitment that my > work won't be wasted. Last I heard, the CriteriaQueryTranslator was > going away and therefore the problem would be fixed by building AST > trees so that the

Re: [hibernate-dev] HHH 869 (Collections of value type in the Criteria API).

2009-06-17 Thread David Mansfield
On Wed, 2009-06-17 at 10:38 -0500, Steve Ebersole wrote: > On Wed, 2009-06-17 at 10:52 -0400, David Mansfield wrote: > > Hi, > > > > I'm not going to do the JUnit stuff until I get a commitment that my > > work won't be wasted. Last I heard, the CriteriaQueryTranslator was > > going away and ther

Re: [hibernate-dev] HHH 869 (Collections of value type in the Criteria API).

2009-06-17 Thread Steve Ebersole
On Wed, 2009-06-17 at 11:55 -0400, David Mansfield wrote: > On Wed, 2009-06-17 at 10:38 -0500, Steve Ebersole wrote: > > On Wed, 2009-06-17 at 10:52 -0400, David Mansfield wrote: > > > Hi, > > > > > > I'm not going to do the JUnit stuff until I get a commitment that my > > > work won't be wasted.

[hibernate-dev] [BV] Path, string or object model

2009-06-17 Thread Emmanuel Bernard
Please review and comment. Begin forwarded message: From: Emmanuel Bernard Date: June 17, 2009 14:41:03 EDT To: Subject: Re: Path, string or object model Here is the solution I cooked. I think it's acceptable but add some complexity in the ConstraintValidatorContext API (see other email).