Re: [hibernate-dev] Possible to confirm that versioning is broken forPersistentSets?

2006-08-31 Thread Josh Moore
Actually had meant doing this in application code. Glad I didn't start. Thanks to the patch on HHH-1668 from Koda Janh, I could get the HHH-1401 test passing. Had to add a protective if-clause around the write statement in PeristentSet.clear() similar to Koda's in PersistentSet.add()/addAll()/r

RE: [hibernate-dev] Possible to confirm that versioning is broken forPersistentSets?

2006-08-31 Thread Steve Ebersole
I've made some changes here locally which attempt to group fixes to a bunch of these seemingly related issues. So for PersistentSet.add() (for example), I have: public boolean add(Object value) { Boolean exists = isOperationQueueEnabled() ?

Re: [hibernate-dev] Possible to confirm that versioning is broken forPersistentSets?

2006-08-31 Thread Josh Moore
Ok. The isDirty()/write()/add()/clearDirty() idiom explains why the patch was producing NPEs in other tests. Otherwise, the only other failures that seemed they could be related were from the optlock tests. Two were failing earlier (see http://opensource.atlassian.com/projects/hibernate/secure/

RE: [hibernate-dev] Possible to confirm that versioning is broken forPersistentSets?

2006-08-31 Thread Steve Ebersole
Oops: protected void configure(Configuration cfg) { super.configure( cfg ); cfg.setProperty( Environment.BATCH_VERSIONED_DATA, "false" ); } The reasoning being that certain drivers (oracle and db2 that I know of) report an "unknown" status for these

RE: [hibernate-dev] Possible to confirm that versioning is broken forPersistentSets?

2006-08-31 Thread Steve Ebersole
OptimisticLockTest was failing on certain databases because the test was poorly written; it was relying on my local setting of not using statement batching for versioned data. I have updated the test to explicitly disable batching of versioned data. Try adding the following to your local copy and

RE: [hibernate-dev] Possible to confirm that versioning is broken forPersistentSets?

2006-08-31 Thread Steve Ebersole
Yes, you've missed something... Your patch does absolutely nothing to ensure that the underlying collection is loaded. That's the reason Josh see's NullPointerExceptions from the test suite when using your patch (the underlying set is null because it has not been initialized). I would guess you

[hibernate-dev] hibernate-mysql-testsuite Build Completed With Testsuite Errors

2006-08-31 Thread qa
View results here -> http://cruisecontrol.jboss.com/cc/buildresults/hibernate-mysql-testsuite?log=log20060831223242 TESTS FAILEDAnt Error Message: /home/cruisecontrol/work/scripts/build-hibernate-db-matrix.xml:127: The following error occurred while executing this line: /home/cruisecontrol/work/sc

[hibernate-dev] hibernate-hsqldb-testsuite Build Completed With Testsuite Errors

2006-08-31 Thread qa
View results here -> http://cruisecontrol.jboss.com/cc/buildresults/hibernate-hsqldb-testsuite?log=log20060831233131 TESTS FAILEDAnt Error Message: /home/cruisecontrol/work/scripts/build-hibernate-db-matrix.xml:92: The following error occurred while executing this line: /home/cruisecontrol/work/sc