Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-19 Thread Adam Warski
Great to hear that :) Thanks for the effort! Adam On Aug 19, 2011, at 4:51 AM, Strong Liu wrote: > okay, https://issues.jboss.org/browse/AS7-928 is resolved and will be > released in AS7 7.0.2, finally :) > > I will write a doc along with > https://docs.jboss.org/author/display/AS7/JPA+Refer

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-19 Thread Scott Marlow
+1 On 08/18/2011 10:51 PM, Strong Liu wrote: > okay, https://issues.jboss.org/browse/AS7-928 is resolved and will be > released in AS7 7.0.2, finally :) > > I will write a doc along with > https://docs.jboss.org/author/display/AS7/JPA+Reference+Guide > > --- > Strong Liu > http://hibern

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-18 Thread Strong Liu
okay, https://issues.jboss.org/browse/AS7-928 is resolved and will be released in AS7 7.0.2, finally :) I will write a doc along with https://docs.jboss.org/author/display/AS7/JPA+Reference+Guide --- Strong Liu http://hibernate.org http://github.com/stliu On Aug 16, 2011, at 8:32 PM,

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-16 Thread Scott Marlow
Strong, Looks good, nice unit tests also! :) Scott On 08/16/2011 12:13 AM, Strong Liu wrote: > Hello guys, > > I just pushed the fix of this issue to my folk, take a look > https://github.com/stliu/jboss-as/commit/4f8bce12c6cc90415d697d321442f827287cde1c > > as https://docs.jboss.org/author/di

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-15 Thread Strong Liu
Hello guys, I just pushed the fix of this issue to my folk, take a look https://github.com/stliu/jboss-as/commit/4f8bce12c6cc90415d697d321442f827287cde1c as https://docs.jboss.org/author/display/AS7/JPA+Reference+Guide said, there are 3 ways to use hibernate (different version) in AS7 1. the de

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-04 Thread Scott Marlow
On 08/04/2011 04:05 AM, Strong Liu wrote: > > --- > Strong Liu > http://hibernate.org > http://github.com/stliu > > On Aug 4, 2011, at 2:48 AM, Adam Warski wrote: > >> >> On Aug 3, 2011, at 5:44 PM, Strong Liu wrote: >> >>> Hi there, >>> >>> I get envers embedded into as7 :D >>> >>> see bel

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-04 Thread Emmanuel Bernard
Interesting, we should add that information in the integrator section of Hibernate Core 4's doc. On 4 août 2011, at 10:34, Strong Liu wrote: > as Adam's post http://www.warski.org/blog/2011/08/using-envers-with-as7/ > if someone create an hibernate integrator, then he should follow adam's > app

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-04 Thread Strong Liu
On Aug 4, 2011, at 12:56 AM, Scott Marlow wrote: > On 08/03/2011 11:44 AM, Strong Liu wrote: >> Hi there, >> >> I get envers embedded into as7 :D >> >> see below: >> >> https://github.com/stliu/hibernate-core/tree/classloading >> https://github.com/stliu/jboss-as/tree/as7-928-2 >> >> 1. org.h

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-04 Thread Strong Liu
as Adam's post http://www.warski.org/blog/2011/08/using-envers-with-as7/ if someone create an hibernate integrator, then he should follow adam's approach create a module for that integrator, which depends on hibernate-core add "Dependencies: ingetrator name services" to app's META-INF no need to

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-04 Thread Strong Liu
--- Strong Liu http://hibernate.org http://github.com/stliu On Aug 4, 2011, at 2:48 AM, Adam Warski wrote: > > On Aug 3, 2011, at 5:44 PM, Strong Liu wrote: > >> Hi there, >> >> I get envers embedded into as7 :D >> >> see below: >> >> https://github.com/stliu/hibernate-core/tree/cl

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-03 Thread Adam Warski
On Aug 3, 2011, at 5:44 PM, Strong Liu wrote: > Hi there, > > I get envers embedded into as7 :D > > see below: > > https://github.com/stliu/hibernate-core/tree/classloading > https://github.com/stliu/jboss-as/tree/as7-928-2 > > 1. org.hibernate module and org.hibernate.envers module depends o

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-03 Thread Emmanuel Bernard
On 3 août 2011, at 19:13, Scott Marlow wrote: > On 08/03/2011 01:03 PM, Emmanuel Bernard wrote: >> >> On 3 août 2011, at 18:56, Scott Marlow wrote: >> >>> On 08/03/2011 11:44 AM, Strong Liu wrote: Hi there, I get envers embedded into as7 :D see below: https

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-03 Thread Scott Marlow
On 08/03/2011 12:56 PM, Scott Marlow wrote: >> 2. org.hibernte.envers module automaticly injected into app when it is a jpa >> project. > This is where it gets tricky to package envers with the app. Have you > synced up with AS7 (7.0.1) master yet? I have another change coming > that could impac

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-03 Thread Scott Marlow
On 08/03/2011 01:03 PM, Emmanuel Bernard wrote: > > On 3 août 2011, at 18:56, Scott Marlow wrote: > >> On 08/03/2011 11:44 AM, Strong Liu wrote: >>> Hi there, >>> >>> I get envers embedded into as7 :D >>> >>> see below: >>> >>> https://github.com/stliu/hibernate-core/tree/classloading >>> https://g

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-03 Thread Emmanuel Bernard
On 3 août 2011, at 18:56, Scott Marlow wrote: > On 08/03/2011 11:44 AM, Strong Liu wrote: >> Hi there, >> >> I get envers embedded into as7 :D >> >> see below: >> >> https://github.com/stliu/hibernate-core/tree/classloading >> https://github.com/stliu/jboss-as/tree/as7-928-2 >> >> 1. org.hibe

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-03 Thread Scott Marlow
On 08/03/2011 11:44 AM, Strong Liu wrote: > Hi there, > > I get envers embedded into as7 :D > > see below: > > https://github.com/stliu/hibernate-core/tree/classloading > https://github.com/stliu/jboss-as/tree/as7-928-2 > > 1. org.hibernate module and org.hibernate.envers module depends on each oth

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-02 Thread Adam Warski
On Aug 2, 2011, at 3:41 PM, Scott Marlow wrote: > It is probably easier to integrate the Envers as a standalone module that > depends on the AS7 "org.hibernate" module. The "org.hibernate" module needs > to depend on "envers" as well (to satisfy the circular dependency). We > should at least

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-02 Thread Scott Marlow
It is probably easier to integrate the Envers as a standalone module that depends on the AS7 "org.hibernate" module. The "org.hibernate" module needs to depend on "envers" as well (to satisfy the circular dependency). We should at least try to do it that way. Strong had run into difficulty w

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-08-02 Thread Adam Warski
As a follow-up, I tried adding Envers to a web application deployed on AS7 today, using Hibernate provided with the AS. I got some class loading problems though with dom4j. See the forum discussion: http://community.jboss.org/message/618823#618823 I also tried creating a separate Envers module w

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-20 Thread Adam Warski
On Jun 20, 2011, at 7:56 PM, Scott Marlow wrote: >> >> and adding envers into org.hibernate module, means there will no >> org.hibernate.envers module, and a (jpa) app's classloader can access >> org.hibernate module, right? so it can access envers class too. > > Wrong, just adding envers to

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-20 Thread Strong Liu
On Jun 21, 2011, at 1:56 AM, Scott Marlow wrote: >> >> and adding envers into org.hibernate module, means there will no >> org.hibernate.envers module, and a (jpa) app's classloader can access >> org.hibernate module, right? so it can access envers class too. > > Wrong, just adding envers to

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-20 Thread Scott Marlow
> > and adding envers into org.hibernate module, means there will no > org.hibernate.envers module, and a (jpa) app's classloader can access > org.hibernate module, right? so it can access envers class too. Wrong, just adding envers to org.hibernate (either via a module dependency or the jar di

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-20 Thread Strong Liu
On Jun 20, 2011, at 11:01 PM, Scott Marlow wrote: > > On 06/17/2011 07:22 AM, Steve Ebersole wrote: >> I remember Scott and I discussing this exact issue. Unfortunately I do >> not remember the specifics. java.util.ServiceLoader#load(Class >> service) does use the TCCL, but I think that the end

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-20 Thread Scott Marlow
On 06/17/2011 07:22 AM, Steve Ebersole wrote: > I remember Scott and I discussing this exact issue. Unfortunately I do > not remember the specifics. java.util.ServiceLoader#load(Class > service) does use the TCCL, but I think that the end result of our > discussion was this is ok. > > We need to h

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-17 Thread Steve Ebersole
I remember Scott and I discussing this exact issue. Unfortunately I do not remember the specifics. java.util.ServiceLoader#load(Class service) does use the TCCL, but I think that the end result of our discussion was this is ok. We need to have this call be able to locate services both within

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-17 Thread Adam Warski
Hello, > 1. adding envers into org.hibernate module in as7, so user's app can see both > hibernate and envers class > (with an separate envers module i ran into some cycle dependency issue) So something depends on Envers? > 2. envers throws "listeners were not registed" exception, means hiberna

Re: [hibernate-dev] classloading issue when trying to add envers to as7

2011-06-16 Thread Scott Marlow
FYI, I'm on pto for a few days (family medical issue). I'd like to help you further with this but think it should just wait until next week. Scott On 06/16/2011 07:54 AM, Strong Liu wrote: > Hi there, > > first of all, I have finished this task, and test pass. > but :), i have to make the follo