Re: [hibernate-dev] api/spi/internal package split

2011-05-17 Thread Emmanuel Bernard
The annotation approach is an idea that I like conceptually and that some proposed (wo pushing it further so far). That being said, my work on classes split has shown me that you need to work a lot to get a decent split and a physical package makes it very clear that things are screwed or not y

Re: [hibernate-dev] api/spi/internal package split

2011-05-17 Thread Hardy Ferentschik
On Tue, 17 May 2011 17:17:58 +0200, Steve Ebersole wrote: > I'd also want the javadocs to accurately reflect this distinction. Are > annotations available to doclets? I don't think so. On the other hand the annotation processor could produce something the doclet could then consume. _

Re: [hibernate-dev] api/spi/internal package split

2011-05-17 Thread Steve Ebersole
The use of annotations is an interesting idea. I had not considered that. I'd also want the javadocs to accurately reflect this distinction. Are annotations available to doclets? I am thinking perhaps not, based on my knowledge of @Deprecated On 05/17/2011 09:45 AM, Hardy Ferentschik wrote:

Re: [hibernate-dev] api/spi/internal package split

2011-05-17 Thread Sanne Grinovero
2011/5/17 Hardy Ferentschik : > Hi, > > sorry for reviving this thread so late, but I only now gained more > experience with > this package splitting. > > Personally I don't like it too much. I partly understand the reason, but I > am not > sure if this religious package naming makes sense. > > As

Re: [hibernate-dev] api/spi/internal package split

2011-05-17 Thread Hardy Ferentschik
Hi, sorry for reviving this thread so late, but I only now gained more experience with this package splitting. Personally I don't like it too much. I partly understand the reason, but I am not sure if this religious package naming makes sense. As already mentioned in this thread, there is th

Re: [hibernate-dev] api/spi/internal package split

2011-03-28 Thread Steve Ebersole
On Monday, March 28, 2011, at 12:36 pm, Emmanuel Bernard wrote: > I'd say I like the current approach better than using spi / internal as top > level. > > The only think I would change is rename internal to some shorter version: > - impl > - private > - hidden > - ? > > Another discussion we

Re: [hibernate-dev] api/spi/internal package split

2011-03-28 Thread Emmanuel Bernard
I'd say I like the current approach better than using spi / internal as top level. The only think I would change is rename internal to some shorter version: - impl - private - hidden - ? Another discussion we had on HSearch is whether or not use internal on the package name that is always b