Re: [hibernate-dev] Usage of static fields throughout Hibernate Core

2016-04-28 Thread Hardy Ferentschik
On Thu, 28-Apr-2016 12:49, Steve Ebersole wrote: > Or better better yet let's get moving from HCANN to Jandex! :) Amen! :-) --Hardy signature.asc Description: PGP signature ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jb

Re: [hibernate-dev] Usage of static fields throughout Hibernate Core

2016-04-28 Thread Steve Ebersole
Or better better yet let's get moving from HCANN to Jandex! :) Bottom line, this depends on specific cases. On Thu, Apr 28, 2016 at 7:38 AM Hardy Ferentschik wrote: > Hi, > > On Thu, 28-Apr-2016 13:15, Gunnar Morling wrote: > > Or, yet better, change the method definition in the upstream compo

Re: [hibernate-dev] Usage of static fields throughout Hibernate Core

2016-04-28 Thread Hardy Ferentschik
Hi, On Thu, 28-Apr-2016 13:15, Gunnar Morling wrote: > Or, yet better, change the method definition in the upstream component > (HCANN) so its accessible without jumping through reflective hoops. +1 :-) --Hardy signature.asc Description: PGP signature _

Re: [hibernate-dev] Usage of static fields throughout Hibernate Core

2016-04-28 Thread Gunnar Morling
Or, yet better, change the method definition in the upstream component (HCANN) so its accessible without jumping through reflective hoops. --Gunnar 2016-04-28 12:57 GMT+02:00 Vlad Mihalcea : > Hi, > > I agree with. > > I'll open a new issue and link to this PR and your comment as well. > > Vlad

Re: [hibernate-dev] Usage of static fields throughout Hibernate Core

2016-04-28 Thread Vlad Mihalcea
Hi, I agree with. I'll open a new issue and link to this PR and your comment as well. Vlad On Thu, Apr 28, 2016 at 1:05 PM, Sanne Grinovero wrote: > Hi Vlad, > > there are several components which can safely use static fields, of > course as you say only if their state is not affected by whic

Re: [hibernate-dev] Usage of static fields throughout Hibernate Core

2016-04-28 Thread Sanne Grinovero
Hi Vlad, there are several components which can safely use static fields, of course as you say only if their state is not affected by which SessionFactory is using them. So I would agree on treating those with care: it should always be a warning sign during code reviews and warrant an in-depth ch