Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Guillaume Smet
Done: https://hibernate.atlassian.net/browse/HHH-10059 On Wed, Aug 26, 2015 at 4:23 PM, Steve Ebersole wrote: > It's fine > > On Wed, Aug 26, 2015, 8:54 AM Guillaume Smet > wrote: > >> Nothing yet. Wanted to be sure you weren't against the principle of >> making this method protected. >> >> If

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Steve Ebersole
It's fine On Wed, Aug 26, 2015, 8:54 AM Guillaume Smet wrote: > Nothing yet. Wanted to be sure you weren't against the principle of making > this method protected. > > If you agree with this plan, I'll do the legwork. > > On Wed, Aug 26, 2015 at 3:34 PM, Steve Ebersole > wrote: > >> Is there a

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Guillaume Smet
Nothing yet. Wanted to be sure you weren't against the principle of making this method protected. If you agree with this plan, I'll do the legwork. On Wed, Aug 26, 2015 at 3:34 PM, Steve Ebersole wrote: > Is there a Jira? PR? > > On Wed, Aug 26, 2015, 8:12 AM Guillaume Smet > wrote: > >> Hi S

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Steve Ebersole
Is there a Jira? PR? On Wed, Aug 26, 2015, 8:12 AM Guillaume Smet wrote: > Hi Steve, > > On Thu, May 7, 2015 at 5:37 PM, Guillaume Smet > wrote: > >> >> Yup, EntityManagerFactoryBuilderImpl.populate(SessionFactoryBuilder, >> StandardServiceRegistry) was my favorite spot too but it's currently

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-08-26 Thread Guillaume Smet
Hi Steve, On Thu, May 7, 2015 at 5:37 PM, Guillaume Smet wrote: > > Yup, EntityManagerFactoryBuilderImpl.populate(SessionFactoryBuilder, > StandardServiceRegistry) was my favorite spot too but it's currently > private. Would you mind making it protected? > Working on my backlog for ORM 5 migrat

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-05-07 Thread Guillaume Smet
Yup, populate(SessionFactoryBuilder, StandardServiceRegistry) was my favorite spot too but it's currently private. Would you mind making it protected? Note that if we can do so without subclassing the said internal class, I'm all ears :). This method was inspired by a blog post for 4.2 that I port

Re: [hibernate-dev] Testing Hibernate 5: injecting a Spring managed interceptor

2015-05-06 Thread Steve Ebersole
As outlined in http://docs.jboss.org/hibernate/orm/5.0/topical/html/bootstrap/LegacyBootstrapping.html#_migration, Configuration#setInterceptor calls now map to the SessionFactoryBuilder#applyInterceptor method. So really we need to look at choices for how to influence the Interceptor on SessionFa