FYI... https://hibernate.atlassian.net/browse/HHH-11010
ATM I have this scheduled for 6.0. In an ideal world we would have
performed these deprecations in 5.2 also and removed the deprecated methods
in 6.0. I can certainly be convinced to do this deprecation in 5.2 however
:)
On Sat, Jul 30, 2
Moving this functionality into the Exporter is the correct answer.
Eventually those DIalect methods will go away.
On Sat, Jul 30, 2016 at 3:32 AM Mark Rotteveel wrote:
> On 28-7-2016 18:07, Steve Ebersole wrote:
> > I do think this is an error. I think the proper fix is to first
> > make use of
On 28-7-2016 18:07, Steve Ebersole wrote:
> I do think this is an error. I think the proper fix is to first
> make use of Exporter#getSqlCreateStrings via
> Dialect#getSequenceExporter.
>
> From there, either:
>
> 1. Change the standard Exporter to look at
> Dialect#supportsPooledSequences an
On 2016-07-28 17:07, Steve Ebersole wrote:
> I do think this is an error. I think the proper fix is to first
> make use of Exporter#getSqlCreateStrings via
> Dialect#getSequenceExporter.
>
> From there, either:
>
> * Change the standard Exporter to look at
> Dialect#supportsPooledSequences
I do think this is an error. I think the proper fix is to first make use
of Exporter#getSqlCreateStrings via Dialect#getSequenceExporter.
>From there, either:
1. Change the standard Exporter to look at
Dialect#supportsPooledSequences and deciding which
Dialect#getCreateSequenceStrings f
On 28-7-2016 13:02, Vlad Mihalcea wrote:
> Is it that you get the exception even if the incrementSize is 1? I guess
> this is an issue that we need to open a Jira ticket for it.
Yes, see the code in my initial email: SchemaCreatorImpl always tries to
create a pooled sequence.
Mark
--
Mark Rotte
Is it that you get the exception even if the incrementSize is 1? I guess
this is an issue that we need to open a Jira ticket for it.
On Thu, Jul 28, 2016 at 1:57 PM, Mark Rotteveel
wrote:
> On 28-7-2016 12:22, Vlad Mihalcea wrote:
>
>> Hi Mark,
>>
>> I've just run the PooledHiLoSequenceIdentifie
On 28-7-2016 12:22, Vlad Mihalcea wrote:
> Hi Mark,
>
> I've just run the PooledHiLoSequenceIdentifierTest test after modifying
> the TABLE to SEQUENCE to see how it works and this is what I found:
>
> 1. SchemaCreatorImpl calls String[] getCreateSequenceStrings(String
> sequenceName, int initialVa
Hi Mark,
I've just run the PooledHiLoSequenceIdentifierTest test after modifying the
TABLE to SEQUENCE to see how it works and this is what I found:
1. SchemaCreatorImpl calls String[] getCreateSequenceStrings(String
sequenceName, int initialValue, int incrementSize)
2. The String getCreateSequen
