Re: [hibernate-dev] Query#iterate

2017-02-02 Thread Steve Ebersole
https://hibernate.atlassian.net/browse/HHH-11443 On Sat, Jan 28, 2017 at 6:38 PM andrea boriero wrote: > +1 to remove > > On 28 Jan 2017 20:44, "Chris Cranford" wrote: > > > +1 to remove as well > > > > > > On 01/27/2017 01:50 PM, Sanne Grinovero wrote: > > > +1 to remove > > > > > > On 27 Janu

Re: [hibernate-dev] Query#iterate

2017-01-28 Thread andrea boriero
+1 to remove On 28 Jan 2017 20:44, "Chris Cranford" wrote: > +1 to remove as well > > > On 01/27/2017 01:50 PM, Sanne Grinovero wrote: > > +1 to remove > > > > On 27 January 2017 at 18:34, Vlad Mihalcea > wrote: > >> I'm for removing it even if it didn't complicate the query parser. > >> > >> V

Re: [hibernate-dev] Query#iterate

2017-01-28 Thread Chris Cranford
+1 to remove as well On 01/27/2017 01:50 PM, Sanne Grinovero wrote: > +1 to remove > > On 27 January 2017 at 18:34, Vlad Mihalcea wrote: >> I'm for removing it even if it didn't complicate the query parser. >> >> Vlad >> >> On Fri, Jan 27, 2017 at 8:26 PM, Steve Ebersole wrote: >> >>> Because t

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Vlad Mihalcea
They can always emulate it with a query that returns the ids and then just call entityManager.find for each id so I don't think we'll ever need to add it back. Vlad On Fri, Jan 27, 2017 at 9:16 PM, Christian Beikov < christian.bei...@gmail.com> wrote: > +1 for remove then too. We can still add i

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Christian Beikov
+1 for remove then too. We can still add it later via a configuration property if someone complains. Am 27.01.2017 um 19:50 schrieb Sanne Grinovero: > +1 to remove > > On 27 January 2017 at 18:34, Vlad Mihalcea wrote: >> I'm for removing it even if it didn't complicate the query parser. >> >> Vl

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Sanne Grinovero
+1 to remove On 27 January 2017 at 18:34, Vlad Mihalcea wrote: > I'm for removing it even if it didn't complicate the query parser. > > Vlad > > On Fri, Jan 27, 2017 at 8:26 PM, Steve Ebersole wrote: > >> Because the behavior is also fundamentally questionable. >> >> On Fri, Jan 27, 2017 at 12:1

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Vlad Mihalcea
I'm for removing it even if it didn't complicate the query parser. Vlad On Fri, Jan 27, 2017 at 8:26 PM, Steve Ebersole wrote: > Because the behavior is also fundamentally questionable. > > On Fri, Jan 27, 2017 at 12:17 PM Christian Beikov < > christian.bei...@gmail.com> wrote: > > > I'm sorry,

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Steve Ebersole
Because the behavior is also fundamentally questionable. On Fri, Jan 27, 2017 at 12:17 PM Christian Beikov < christian.bei...@gmail.com> wrote: > I'm sorry, I apparently confused iterate() with scroll() then, so forget > what I wrote before ^^ > > In face of that new info, I actually don't know o

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Christian Beikov
I'm sorry, I apparently confused iterate() with scroll() then, so forget what I wrote before ^^ In face of that new info, I actually don't know of any actual users. After thinking a bit about it, why not make that behavior configurable via setProperty and drop that method? Am 27.01.2017 um 19:

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Steve Ebersole
On Fri, Jan 27, 2017 at 9:51 AM Christian Beikov wrote: > I just know of people that are using iterate() now for efficient > incremental processing, but I guess any other approach(streams maybe?) > to do incremental processing would be good enough for these users. > > ScrollableResults do not mee

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Vlad Mihalcea
I would not bother too much about iterate since it can be easily emulated with an entity query. If I recall correctly, Query#iterate does something like this: select e.id from Entity e where condition and for every identifier we can load the entity from the 2nd-level cache instead of loading it f

Re: [hibernate-dev] Query#iterate

2017-01-27 Thread Christian Beikov
I just know of people that are using iterate() now for efficient incremental processing, but I guess any other approach(streams maybe?) to do incremental processing would be good enough for these users. Unfortunately I don't know what a shallow query is or what the implication on the query or t