Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-18 Thread Steve Ebersole
I finished going through this second iteration. I started color each finding to better indicate its "status": - Blue = converted to a Jira - Red = things I do not think we want to change (migration guide) - Green = things that I considered "open items" - we should discuss further All

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-06 Thread Sanne Grinovero
On 6 April 2018 at 14:56, Steve Ebersole wrote: > That's called a migration guide :) Good point :) > > And I agree, we should capture behavioral differences there too. > > On Fri, Apr 6, 2018 at 8:51 AM Sanne Grinovero wrote: >> >> On 5 April 2018 at 22:03, Steve Ebersole wrote: >> > I am assu

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-06 Thread Steve Ebersole
That's called a migration guide :) And I agree, we should capture behavioral differences there too. On Fri, Apr 6, 2018 at 8:51 AM Sanne Grinovero wrote: > On 5 April 2018 at 22:03, Steve Ebersole wrote: > > I am assuming that mean you behavioral compatibility (they act the > same)... > > > >

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-06 Thread Sanne Grinovero
On 5 April 2018 at 22:03, Steve Ebersole wrote: > I am assuming that mean you behavioral compatibility (they act the same)... > > Well that's the point of tests. The real problem is that often there are > not tests for a specific thing or someone changed the test expectations > during development

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-05 Thread Steve Ebersole
I am assuming that mean you behavioral compatibility (they act the same)... Well that's the point of tests. The real problem is that often there are not tests for a specific thing or someone changed the test expectations during development On Thu, Apr 5, 2018 at 3:56 PM Sanne Grinovero wrote:

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-05 Thread Sanne Grinovero
This report is focusing on binary compatibility. Which is great, but we should also pay attention to some other significant incompatibilities such as HHH-12454. How do you prefer to track those, if at all? David mentioned that we're only *required* to provide binary compatibility, but we could of

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-05 Thread Steve Ebersole
Awesome! I'm sure that took a lot of work - thank you On Thu, Apr 5, 2018 at 3:48 PM Gail Badner wrote: > I basically re-ran the same report on the newer snapshots. > Incompatibilities listed in the old report that were resolved do not appear > in the new report. > > I also categorized the inco

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-05 Thread Gail Badner
I basically re-ran the same report on the newer snapshots. Incompatibilities listed in the old report that were resolved do not appear in the new report. I also categorized the incompatibilities as discussed in comments in the second report (e.g., Failures Mitigated using Compatibility Transformer

Re: [hibernate-dev] New report for API incompatibilities between 5.1 and 5.3

2018-04-04 Thread Steve Ebersole
Are these in addition to the original documentation? How do we correlate things from this new doc that have already been addressed via the previous? On Tue, Apr 3, 2018 at 8:00 PM Gail Badner wrote: > I've re-run the report to see what is still outstanding. > > Here's the link: > > https://docs