I don't like it too much either. As Steve was saying, there are pro and
cons
and it is only required, because maven 'forces' you down this path.
For now I will just commit hibernate-search-testing (effectively
duplicating
the test utility classes). We see how this goes and take it from there.
Honestly, had Maven not forced me to I would not have for Core either.
On 03/22/2010 05:19 AM, Emmanuel Bernard wrote:
> If you ask me, I think moving core tests away from the core module(s) is not
> the right thing to do for hibernate search.
>
> On 20 mars 2010, at 20:35, Hardy Ferentschik wrot
If you ask me, I think moving core tests away from the core module(s) is not
the right thing to do for hibernate search.
On 20 mars 2010, at 20:35, Hardy Ferentschik wrote:
> Ok, locally I have now the following structure
>
> pom.xml
> hibernate-search/
> hibernate-search-archetype/
> hibernate
Well I can only speak from core and why we decided to make the split there.
hibernate-testing is all the classes which are useful for writing tests.
Stuff like our test base classes and our trivial JTA TM impl.
Specifically stuff that is useful for writing *functional* tests.
hibernate-testsu
it's ok for me because of your "consistency with core" argument but I
have no clue about why this setup is useful.
(I like consistency, but had to hang this poster as a reminder in my
room: http://site.despair.com/images/dpage/consistency03.jpg)
I'm still wondering what's the difference between:
h
Ok, locally I have now the following structure
pom.xml
hibernate-search/
hibernate-search-archetype/
hibernate-search-testing/
hibernate-search-testsuite/
Tests are split out into hibernate-search-testsuite. We can still leave
tests which don't extend
SearchTestCase in hibernate-search, but the
Regarding the test util module (hibernate-search-testing). If we are
planning to split out
the different clustering parts (or for any other later module) we probably
want to
have all the test base classes in hibernate-search-testing as well (eg
SearchTestCase).
Obviously SearchTestCase depend
On 17 mars 2010, at 10:55, Sanne Grinovero wrote:
> 2010/3/17 Emmanuel Bernard :
>>
>> On 17 mars 2010, at 10:31, Sanne Grinovero wrote:
>>
Four options here:
- do this -util module
- do a -testsuite module
- do the test artifact (Sanne's current commit)
- do
2010/3/17 Emmanuel Bernard :
>
> On 17 mars 2010, at 10:31, Sanne Grinovero wrote:
>
>>>
>>> Four options here:
>>> - do this -util module
>>> - do a -testsuite module
>>> - do the test artifact (Sanne's current commit)
>>> - do not split the 3 util classes out
>>>
>>> So far I think the last t
On 17 mars 2010, at 10:31, Sanne Grinovero wrote:
>>
>> Four options here:
>> - do this -util module
>> - do a -testsuite module
>> - do the test artifact (Sanne's current commit)
>> - do not split the 3 util classes out
>>
>> So far I think the last two solutions are the less annoying
>>
2010/3/16 Emmanuel Bernard :
>
> On 16 mars 2010, at 20:05, Hardy Ferentschik wrote:
>
>> On Tue, 16 Mar 2010 15:38:40 -0300, Emmanuel Bernard
>> wrote:
>>
>>> What's the list of all potential modules? Then let's see if we want to
>>> minimize some or create bundles
>>>
>>> hibernate-search-core
On 16 mars 2010, at 20:05, Hardy Ferentschik wrote:
> On Tue, 16 Mar 2010 15:38:40 -0300, Emmanuel Bernard
> wrote:
>
>> What's the list of all potential modules? Then let's see if we want to
>> minimize some or create bundles
>>
>> hibernate-search-core
>
> Here I had in mind to use just h
On Tue, 16 Mar 2010 15:38:40 -0300, Emmanuel Bernard
wrote:
> What's the list of all potential modules? Then let's see if we want to
> minimize some or create bundles
>
> hibernate-search-core
Here I had in mind to use just hibernate-search so that the main artifact
keeps its name.
> hibe
What's the list of all potential modules? Then let's see if we want to minimize
some or create bundles
hibernate-search-core
hibernate-search-hibernate
hibernate-search-jpa
hibernate-search-jms
hibernate-search-jgroups
hibernate-search-infinispan
hibernate-search-util //could be use to avoid the
2010/3/16 Hardy Ferentschik :
> Hi,
>
> I started on the modularization of Search (HSEARCH-468) and would like to
> get some feedback.
nice, the build is still working for me :)
> So far all I've done is to create a parent pom and push the main code into
> the hibernate-search module.
>
> The lay
15 matches
Mail list logo
