Re: [hibernate-dev] Interceptor question

2012-05-14 Thread Hardy Ferentschik
>>> +0,8 to optionally (with a boolean) enable interception on those >>> methods. I guess it might be handy, but I'm not fully convinced on >>> their use and it's yet-another-method, we're getting a bit complex. >>> At least it's better than always applying the interceptor as the >>> missing metho

Re: [hibernate-dev] Interceptor question

2012-05-14 Thread Sanne Grinovero
On 14 May 2012 15:50, Hardy Ferentschik wrote: > > On May 13, 2012, at 11:17 PM, Sanne Grinovero wrote: > >> I agree as a user it's not simple to deal with two "massindex" >> approaches, even worse if they behave differently. Your >> straight-forward take on it is to make sure they behave the same

Re: [hibernate-dev] Interceptor question

2012-05-14 Thread Hardy Ferentschik
On May 13, 2012, at 11:17 PM, Sanne Grinovero wrote: > I agree as a user it's not simple to deal with two "massindex" > approaches, even worse if they behave differently. Your > straight-forward take on it is to make sure they behave the same, and > I see some good value in it.. still we end up h

Re: [hibernate-dev] Interceptor question

2012-05-14 Thread Hardy Ferentschik
On May 14, 2012, at 4:22 PM, Sanne Grinovero wrote: > So the essential question is, for people using index / purge / > purgeAll, to have *manual* control.. by *manual* do we intend that the > user as the last word, or should we still apply interceptors? How does the her not have the last word if

Re: [hibernate-dev] Interceptor question

2012-05-14 Thread Sanne Grinovero
Right I didn't mean to imply that they are just "building blocks" for a do-it-yourself massindexer, just that that example using the scrollable resultset is an interesting example of how they can be used. So the essential question is, for people using index / purge / purgeAll, to have *manual* con

Re: [hibernate-dev] Interceptor question

2012-05-14 Thread Emmanuel Bernard
To me index / purge / purgeAll are not simply about what the MassIndexer does. I can see use cases where you manually control indexing without considering doing this en mass. remember, people can disable event based indexing. On 13 mai 2012, at 23:17, Sanne Grinovero wrote: > [thread diverged, no

Re: [hibernate-dev] Interceptor question

2012-05-13 Thread Sanne Grinovero
[thread diverged, not sure how to reply on each point.. so clean sheet:] I agree as a user it's not simple to deal with two "massindex" approaches, even worse if they behave differently. Your straight-forward take on it is to make sure they behave the same, and I see some good value in it.. still

Re: [hibernate-dev] Interceptor question

2012-05-12 Thread Hardy Ferentschik
On May 11, 2012, at 20:22, Emmanuel Bernard wrote: > The reason I did map manual indexing to apply default is that I sided with > Sanne s reasoning and I went on the side of caution with the API. I'd love to > get more practical feedback before deciding to either: > > - stay as it is > - m

Re: [hibernate-dev] Interceptor question

2012-05-12 Thread Hardy Ferentschik
> Since the filter is user defined, based on the fact that the user > *knows* the blog needs to be indexed only when [businessrule], > it's not hard to adapt the code using an > > if [businessrule] { > fulltextSession#index( e ); > } > else { > log.discardBlogDRAFTFromIndex( e ); > } Not hard,

Re: [hibernate-dev] Interceptor question

2012-05-11 Thread Emmanuel Bernard
The reason I did map manual indexing to apply default is that I sided with Sanne s reasoning and I went on the side of caution with the API. I'd love to get more practical feedback before deciding to either: - stay as it is - map indexing and purge to the interceptor - I don't think we can safel

Re: [hibernate-dev] Interceptor question

2012-05-11 Thread Sanne Grinovero
On 11 May 2012 17:15, Hardy Ferentschik wrote: > > On May 11, 2012, at 6:07 PM, Sanne Grinovero wrote: > >> I was expecting you to argue about it, > > :-) > > >> and therefore I concede that >> some docs clarification at least is strongly required, > > at the very least no doubt > >> but I disag

Re: [hibernate-dev] Interceptor question

2012-05-11 Thread Hardy Ferentschik
On May 11, 2012, at 6:07 PM, Sanne Grinovero wrote: > I was expecting you to argue about it, :-) > and therefore I concede that > some docs clarification at least is strongly required, at the very least > but I disagree on the expectations: > > I see a fundamental difference in behaviour ex

Re: [hibernate-dev] Interceptor question

2012-05-11 Thread Sanne Grinovero
I was expecting you to argue about it, and therefore I concede that some docs clarification at least is strongly required, but I disagree on the expectations: I see a fundamental difference in behaviour expectations between a) "sync up database and index" b) "index Entries A and B now" In the f

Re: [hibernate-dev] Interceptor question

2012-05-11 Thread Hardy Ferentschik
Really? I would argue differently. Let's take the blog example where I only want to index blog entries which are published. Adding the interceptor and relying on automatic indexing will not index un-published entries. Great. If I, however, want/ have to re-index my blog entries via the API the