Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-14 Thread Guillaume Smet
Hi, Here we go for the current state of my work and what I would like to do: https://hibernate.atlassian.net/browse/HSEARCH-1392 I created a PR so that we can discuss the changes already made: https://github.com/hibernate/hibernate-search/pull/472 Thanks for your feedback. -- Guillaume ___

Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-13 Thread Sanne Grinovero
On 13 August 2013 10:41, Guillaume Smet wrote: > On Tue, Aug 13, 2013 at 10:58 AM, Sanne Grinovero wrote: >> On 13 August 2013 09:12, Guillaume Smet wrote: >>> Hi, >>> >>> I'm planning to work on the pom files in the next few days. >>> >>> Here is more or less the plan I have in mind: >>> - cent

Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-13 Thread Hardy Ferentschik
I am all for cleaning up. Aside the things discussed here I would like to follow up on HSEARCH-933. The database profiles defined in the parent pom have imo no business there. They just create unnecessary noise. Initially I thought we could use a separate settings.xml, but I think you cannot ad

Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-13 Thread Guillaume Smet
On Tue, Aug 13, 2013 at 10:58 AM, Sanne Grinovero wrote: > On 13 August 2013 09:12, Guillaume Smet wrote: >> Hi, >> >> I'm planning to work on the pom files in the next few days. >> >> Here is more or less the plan I have in mind: >> - centralize all dependencies versions in the properties of the

Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-13 Thread Gunnar Morling
Hi Guillaume, Sounds great, nothing much to add to what Sanne said. Regarding properties for versions, I think it's only worth it in case a given version is used several times (e.g. by several "modules" of a dependency which all should be pulled in in the same version). Otherwise I think it enoug

Re: [hibernate-dev] HSEARCH - Assorted fixes to the pom files

2013-08-13 Thread Sanne Grinovero
On 13 August 2013 09:12, Guillaume Smet wrote: > Hi, > > I'm planning to work on the pom files in the next few days. > > Here is more or less the plan I have in mind: > - centralize all dependencies versions in the properties of the parent > pom file. A couple of them are directly in the dependenc