Re: [hibernate-dev] Closed pull requests

2014-12-07 Thread Andrej Golovnin
> On 02.12.2014, at 00:31, Steve Ebersole wrote: > > I am finishing up the initial 5.0 work for master right now. I will work on > these next. Ping me at the end of the week so I dont forget :) Ping. :) > > On Mon, Dec 1, 2014 at 3:07 PM, Andrej Golovnin wrote: > > > They should get move

Re: [hibernate-dev] Closed pull requests

2014-12-03 Thread Sanne Grinovero
On 3 December 2014 at 14:46, Steve Ebersole wrote: > Yes and no. The issues are closed *against 6.0*, which is still technically > correct for the current state. The changes are still integrated into the > metamodel branch which correlates to 6.0 in jira. > > The question is more *which* of thos

Re: [hibernate-dev] Closed pull requests

2014-12-03 Thread Steve Ebersole
Yes and no. The issues are closed *against 6.0*, which is still technically correct for the current state. The changes are still integrated into the metamodel branch which correlates to 6.0 in jira. The question is more *which* of those changes we want to migrate to master. On Wed, Dec 3, 2014

Re: [hibernate-dev] Closed pull requests

2014-12-03 Thread Sanne Grinovero
Don't you all think it's very troubling that several issues in JIRA are marked as "resolved" but are not actually integrated in the new master? This query is probably not perfect but I hope it's enough to highlight the problem: https://hibernate.atlassian.net/issues/?filter=15161&jql=project%20%3D

Re: [hibernate-dev] Closed pull requests

2014-12-01 Thread Steve Ebersole
I am finishing up the initial 5.0 work for master right now. I will work on these next. Ping me at the end of the week so I dont forget :) On Mon, Dec 1, 2014 at 3:07 PM, Andrej Golovnin wrote: > > > They should get moved to the 4.3-based master. I think I found the > relevant issues: > > > >

Re: [hibernate-dev] Closed pull requests

2014-12-01 Thread Andrej Golovnin
> They should get moved to the 4.3-based master. I think I found the relevant > issues: > > * Oracle12cDialect - https://hibernate.atlassian.net/browse/HHH-9044 > * PostgreSQL92Dialect & PostgreSQL94Dialect - > https://hibernate.atlassian.net/browse/HHH-9167 > > I have reopened them and targe

Re: [hibernate-dev] Closed pull requests

2014-12-01 Thread Steve Ebersole
They should get moved to the 4.3-based master. I think I found the relevant issues: * Oracle12cDialect - https://hibernate.atlassian.net/browse/HHH-9044 * PostgreSQL92Dialect & PostgreSQL94Dialect - https://hibernate.atlassian.net/browse/HHH-9167 I have reopened them and targeted them for 5.0

Re: [hibernate-dev] Closed pull requests

2014-11-27 Thread Andrej Golovnin
Hi Steve, > > https://github.com/hibernate/hibernate-orm/pull/777 > > > > > > > Overall, checking that the PR still applies is a good idea too. while working on a new pull request for the issue HHH-9324 I have noticed that the new master misses some dialects: Oracle12cDialect PostgreSQL92Dialec

Re: [hibernate-dev] Closed pull requests

2014-10-31 Thread Steve Ebersole
I knew what you meant. I already re-opened those earlier On Fri, Oct 31, 2014 at 2:11 AM, Andrej Golovnin wrote: > > > Here are mines: > > I mean from me. I should not write emails early in the morning. I was > still asleep. :-) > > > https://github.com/hibernate/hibernate-orm/pull/779 > > http

Re: [hibernate-dev] Closed pull requests

2014-10-31 Thread Andrej Golovnin
> Here are mines: I mean from me. I should not write emails early in the morning. I was still asleep. :-) > https://github.com/hibernate/hibernate-orm/pull/779 > https://github.com/hibernate/hibernate-orm/pull/782 > https://github.com/hibernate/hibernate-orm/pull/777 > > > > Overall, checking

Re: [hibernate-dev] Closed pull requests

2014-10-30 Thread Andrej Golovnin
> On 30.10.2014, at 23:43, Steve Ebersole wrote: > > Well telling me/us which PRs got closed would be a good first step :) Here are mines: https://github.com/hibernate/hibernate-orm/pull/779 https://github.com/hibernate/hibernate-orm/pull/782 https://github.com/hibernate/hibernate-orm/pull/777

Re: [hibernate-dev] Closed pull requests

2014-10-30 Thread Steve Ebersole
Well telling me/us which PRs got closed would be a good first step :) Overall, checking that the PR still applies is a good idea too. On Thu, Oct 30, 2014 at 5:34 PM, Andrej Golovnin wrote: > > > On 30.10.2014, at 23:15, Steve Ebersole wrote: > > > > Well maybe rather than being hurt and sensi