Re: [hibernate-dev] Cache region names are not prefixed in 5.3

Ignore me, panicked too quickly... the dot is added there in 5.1 as well. On 05/18/2018 09:37 AM, Radim Vansa wrote: > One thing I've stumbled upon: it seems that RegionFactory should call > its method qualify(String regionName) to produce the prefixed region > name. Following Hibernate's implem

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

One thing I've stumbled upon: it seems that RegionFactory should call its method qualify(String regionName) to produce the prefixed region name. Following Hibernate's implementation I use RegionNameQualifier for this, which uses prefix + '.' + regionName. In previous versions the dot was missin

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

On 05/18/2018 02:54 AM, Gail Badner wrote: > > > On Thu, May 17, 2018 at 5:24 PM, Gail Badner > wrote: > > I see that HHH-11356 removed prefixes from region names used by > Hibernate. > > I also noticed that entity regions are unprefixed and the package >

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

On Thu, May 17, 2018 at 5:24 PM, Gail Badner wrote: > I see that HHH-11356 removed prefixes from region names used by Hibernate. > > I also noticed that entity regions are unprefixed and the package name is > removed. > Actually, the package names are being included in the region names. The test

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

I see that HHH-11356 removed prefixes from region names used by Hibernate. I also noticed that entity regions are unprefixed and the package name is removed. I've created 2 issues: HHH-12599 to add Javadoc to make it clear that region names are unprefixed; HHH-12598 to add the package onto entity

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

On 17 May 2018 at 12:09, Radim Vansa wrote: > I basically agree with Sanne here that having the prefix isolated opens > space for performance improvements, though if certain call is prefixed, > RegionFactory can always drop that prefix. The important thing is to mention > if the region name is pre

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

I basically agree with Sanne here that having the prefix isolated opens space for performance improvements, though if certain call is prefixed, RegionFactory can always drop that prefix. The important thing is to mention if the region name is prefixed or not in javadocs. I would also prefer if

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

On 17 May 2018 at 11:11, Sanne Grinovero wrote: > I think this is the RegionFactory's responsibility, as Hibernate ORM > alone can't know if this is necessary. > > Prefixing is one of many options to isolate caches; a Cache technology > might wish to use a different approach by implementing a cust

Re: [hibernate-dev] Cache region names are not prefixed in 5.3

I think this is the RegionFactory's responsibility, as Hibernate ORM alone can't know if this is necessary. Prefixing is one of many options to isolate caches; a Cache technology might wish to use a different approach by implementing a custom `org.hibernate.cache.spi.CacheKeysFactory`. Not least