Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Chris Dennis
+1. From my point of view this makes sense. I’ll need to confer with higher-ups about what we would then do regarding our copy of the Ehcache 2.x provider and whether we want to port it across to the new SPI. That should in principle be a separate discussion, but I’m a little too heads-down in

Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Steve Ebersole
On Thu, Mar 15, 2018 at 9:30 AM Radim Vansa wrote: > Before Infinispan provides native implementation to 5.3/6.0 SPIs, JCache > is a good way to bridge the gap. So if you're setting up a matrix > testing, adding Infinispan JCache provider would give us some confidence > that we can recommend that

Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Steve Ebersole
I'd have to look at the tests :) On Thu, Mar 15, 2018 at 9:46 AM Sanne Grinovero wrote: > On 15 March 2018 at 13:58, Steve Ebersole wrote: > > On Thu, Mar 15, 2018 at 8:47 AM Sanne Grinovero > wrote: > >> > >> > >> BTW what about all of Alex's sophisticated integration tests? I assume > >> th

Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Sanne Grinovero
On 15 March 2018 at 13:58, Steve Ebersole wrote: > On Thu, Mar 15, 2018 at 8:47 AM Sanne Grinovero wrote: >> >> >> BTW what about all of Alex's sophisticated integration tests? I assume >> they are more thorough in the older Ehcache module than in the JCache >> module; would be a shame to lose th

Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Radim Vansa
On 03/15/2018 02:56 PM, Steve Ebersole wrote: > Inline > > On Thu, Mar 15, 2018 at 8:44 AM Sanne Grinovero wrote: > >> On 15 March 2018 at 13:04, Steve Ebersole wrote: >>> Given the changes to the second-level cache SPI, I wonder if we want to >>> take that as an opportunity to consider dropp

Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Steve Ebersole
Inline On Thu, Mar 15, 2018 at 8:44 AM Sanne Grinovero wrote: > On 15 March 2018 at 13:04, Steve Ebersole wrote: > > Given the changes to the second-level cache SPI, I wonder if we want to > > take that as an opportunity to consider dropping the `hibernate-ehcache` > > module? > > > > There

Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Sanne Grinovero
On 15 March 2018 at 13:44, Sanne Grinovero wrote: > On 15 March 2018 at 13:04, Steve Ebersole wrote: >> Given the changes to the second-level cache SPI, I wonder if we want to >> take that as an opportunity to consider dropping the `hibernate-ehcache` >> module? >> >> There are a few reasons I am

Re: [hibernate-dev] 5.3 - hibernate-ehcache

2018-03-15 Thread Sanne Grinovero
On 15 March 2018 at 13:04, Steve Ebersole wrote: > Given the changes to the second-level cache SPI, I wonder if we want to > take that as an opportunity to consider dropping the `hibernate-ehcache` > module? > > There are a few reasons I am considering this... > >1. We have the JCache integrat