Re: [hibernate-dev] 5.0 defaults

2015-08-05 Thread Steve Ebersole
Ok, I am changing my mind ImplicitNamingStratregy as well. Gail's "annotation javadoc" argument swayed me. I have already changed the defaults for keyword-auto-quoting (to false) and use-new-generator-mappings (to true). I will add a change for the default ImplicitNamingStratregy as well for CR4

Re: [hibernate-dev] 5.0 defaults

2015-08-04 Thread Steve Ebersole
For what it is worth... At the moment I am leaning towards changing the defaults for: 1) "use new id generator mappings" -> true 2) "auto quote keywords" -> false As I mentioned, to me changing any of these defaults warrants a new CR (and obviously documenting in the migration guide). I plan on

Re: [hibernate-dev] 5.0 defaults

2015-08-04 Thread Steve Ebersole
On Tue, Aug 4, 2015 at 1:51 AM Gail Badner wrote: > > IMO, the JPA annnotations should generate tables/columns/etc that are > JPA-compliant by default. If a developer is adding JPA annotations, I think > there is a pretty good likelihood they will be referring to Javadoc or > looking at the annno

Re: [hibernate-dev] 5.0 defaults

2015-08-03 Thread Gail Badner
I mentioned my concerns about hibernate.implicit_naming_strategy and auto-quoting keywords when I was getting the standalone TCK working with master. Here are my thoughts... On 08/03/2015 02:17 PM, Steve Ebersole wrote: > 1) hibernate.implicit_naming_strategy - by default Hibernate uses its > le

Re: [hibernate-dev] 5.0 defaults

2015-08-03 Thread Scott Marlow
On 08/03/2015 04:00 PM, Steve Ebersole wrote: > On Mon, Aug 3, 2015 at 2:07 PM Scott Marlow > wrote: > > > > On 08/03/2015 02:17 PM, Steve Ebersole wrote: > > Scott has been asking about making some setting defaults > consistent between > > Hibernate

Re: [hibernate-dev] 5.0 defaults

2015-08-03 Thread Steve Ebersole
On Mon, Aug 3, 2015 at 2:07 PM Scott Marlow wrote: > > > On 08/03/2015 02:17 PM, Steve Ebersole wrote: > > Scott has been asking about making some setting defaults consistent > between > > Hibernate and WildFly. Most I think WildFly should just use the ORM > > defaults. > > If ORM 5.0 used the

Re: [hibernate-dev] 5.0 defaults

2015-08-03 Thread Scott Marlow
On 08/03/2015 02:17 PM, Steve Ebersole wrote: > Scott has been asking about making some setting defaults consistent between > Hibernate and WildFly. Most I think WildFly should just use the ORM > defaults. If ORM 5.0 used the same defaults as the WildFly (JPA) deployer, then WildFly could sto